fix: ignore codecov check suite #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
approved these changes
Aug 7, 2024
aduh95
reviewed
Aug 7, 2024
lib/pr_checker.js
Outdated
| if (app && app.slug === 'dependabot') { | ||
| // Ignore Dependabot check suites. They are expected to show up | ||
| if (app && IGNORED_CHECK_SLUGS.includes(app.slug)) { | ||
| // Ignore app check suites. They are expected to show up |
There was a problem hiding this comment.
Suggested change
| // Ignore app check suites. They are expected to show up | |
| // Ignore GitHub Apps check suites. They are expected to show up |
That makes me think; should we filter only status for checks from {"slug":"github-actions"} instead of trying to maintain a list of Apps we have installed?
There was a problem hiding this comment.
Might be fine as long as we don't require checks from other apps :)
There was a problem hiding this comment.
I think just ignoring dependabot and codecov is fine for now, but if the project installs more apps, maybe then ignore all apps.
There was a problem hiding this comment.
Well in this case, we should have the comment align with what the code is doing
Suggested change
| // Ignore app check suites. They are expected to show up | |
| // Ignore Dependabot and Codecov check suites. They are expected to show up |
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://openjs-foundation.slack.com/archives/C019MGJQ8RH/p1722871958000979