Skip to content

fix: ignore codecov check suite #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2024
Merged

fix: ignore codecov check suite #838

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd7590c
fix: ignore codecov check suite
avivkeller Aug 6, 2024
72fa826
Update pr_checker.js
avivkeller Aug 7, 2024
d74e0ec
Update pr_checker.js
avivkeller Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/pr_checker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ const GITHUB_SUCCESS_CONCLUSIONS = ['SUCCESS', 'NEUTRAL', 'SKIPPED'];
const FAST_TRACK_RE = /^Fast-track has been requested by @(.+?)\. Please 👍 to approve\.$/;
const FAST_TRACK_MIN_APPROVALS = 2;
const GIT_CONFIG_GUIDE_URL = 'https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork';
const IGNORED_CHECK_SLUGS = ['dependabot', 'codecov'];

// eslint-disable-next-line no-extend-native
Array.prototype.findLastIndex ??= function findLastIndex(fn) {
Expand Down Expand Up @@ -373,8 +374,8 @@ export default class PRChecker {

// GitHub new Check API
for (const { status, conclusion, app } of checkSuites.nodes) {
if (app && app.slug === 'dependabot') {
// Ignore Dependabot check suites. They are expected to show up
if (app && IGNORED_CHECK_SLUGS.includes(app.slug)) {
// Ignore app check suites. They are expected to show up
Copy link
Contributor

@aduh95 aduh95 Aug 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Ignore app check suites. They are expected to show up
// Ignore GitHub Apps check suites. They are expected to show up

That makes me think; should we filter only status for checks from {"slug":"github-actions"} instead of trying to maintain a list of Apps we have installed?

Copy link
Member

@targos targos Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be fine as long as we don't require checks from other apps :)

Copy link
Member Author

@avivkeller avivkeller Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just ignoring dependabot and codecov is fine for now, but if the project installs more apps, maybe then ignore all apps.

Copy link
Contributor

@aduh95 aduh95 Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well in this case, we should have the comment align with what the code is doing

Suggested change
// Ignore app check suites. They are expected to show up
// Ignore Dependabot and Codecov check suites. They are expected to show up

// sometimes and never complete.
continue;
}
Expand Down