Skip to content

test: refactor test assertions and comments in napi tests #18414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

test: refactor test assertions and comments in napi tests #18414

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be79f8e
n-api: change assert ok check to not strict equal.
nbdaaron Jan 27, 2018
a909a0c
n-api: change functions to arrow functions.
nbdaaron Jan 27, 2018
4c48354
n-api: fix code to follow style guidelines.
nbdaaron Jan 27, 2018
565f65d
nit: add space before starting comment.
nbdaaron Jan 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
n-api: change assert ok check to not strict equal.
  • Loading branch information
@nbdaaron
nbdaaron committed Jan 27, 2018
commit be79f8eeb50aa3f34e91de96ea6309c57e45a25d
6 changes: 3 additions & 3 deletions test/addons-napi/test_general/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ assert.strictEqual(test_general.testGetPrototype(baseObject),
Object.getPrototypeOf(baseObject));
assert.strictEqual(test_general.testGetPrototype(extendedObject),
Object.getPrototypeOf(extendedObject));
assert.ok(test_general.testGetPrototype(baseObject) !==
test_general.testGetPrototype(extendedObject),
'Prototypes for base and extended should be different');
//Prototypes for base and extended should be different.
Copy link
Member

@lpinca lpinca Jan 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you please add a space after //?

assert.notStrictEqual(test_general.testGetPrototype(baseObject),
test_general.testGetPrototype(extendedObject));

// test version management functions
// expected version is currently 1
Expand Down