pr feedback

doc/api/cli.md

@@ -161,7 +161,7 @@ Currently, overriding `Error.prepareStackTrace` is ignored when the
 added: v12.0.0
 -->
 
-Sets the resolution algorithm for resolving ES modulespecifiers. Valid options
+Sets the resolution algorithm for resolving ES module specifiers. Valid options
 are `explicit` and `node`.
 
 The default is `explicit`, which requires providing the full path to a

doc/api/vm.md

@@ -88,7 +88,8 @@ changes:
   * `importModuleDynamically` {Function} Called during evaluation of this module
     when `import()` is called. If this option is not specified, calls to
     `import()` will reject with [`ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING`][].
-    flag, and should not be considered stable.
+    This option is part of the experimental modules API, and should not be
+    considered stable.
     * `specifier` {string} specifier passed to `import()`
     * `module` {vm.Module}
     * Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is
@@ -853,7 +854,8 @@ changes:
   * `importModuleDynamically` {Function} Called during evaluation of this module
     when `import()` is called. If this option is not specified, calls to
     `import()` will reject with [`ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING`][].
-    flag, and should not be considered stable.
+    This option is part of the experimental modules API, and should not be
+    considered stable.
     * `specifier` {string} specifier passed to `import()`
     * `module` {vm.Module}
     * Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is
@@ -949,7 +951,8 @@ changes:
   * `importModuleDynamically` {Function} Called during evaluation of this module
     when `import()` is called. If this option is not specified, calls to
     `import()` will reject with [`ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING`][].
-    flag, and should not be considered stable.
+    This option is part of the experimental modules API, and should not be
+    considered stable.
     * `specifier` {string} specifier passed to `import()`
     * `module` {vm.Module}
     * Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is
@@ -1025,7 +1028,8 @@ changes:
   * `importModuleDynamically` {Function} Called during evaluation of this module
     when `import()` is called. If this option is not specified, calls to
     `import()` will reject with [`ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING`][].
-    flag, and should not be considered stable.
+    This option is part of the experimental modules API, and should not be
+    considered stable.
     * `specifier` {string} specifier passed to `import()`
     * `module` {vm.Module}
     * Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is

doc/node.1

@@ -205,7 +205,7 @@ It uses the Chrome DevTools Protocol.
 .It Fl -experimental-loader Ns = Ns Ar module
 Specify the
 .Ar module
-as a custom loader, to load
+to use as a custom module loader.
 .
 .It Fl -max-http-header-size Ns = Ns Ar size
 Specify the maximum size of HTTP headers in bytes. Defaults to 8KB.

lib/internal/bootstrap/pre_execution.js

@@ -465,9 +465,6 @@ function shouldUseESMLoader(mainPath) {
 }
 
 function runMainESM(mainPath) {
-  process.emitWarning(
-    'The ESM module loader is experimental.',
-    'ExperimentalWarning', undefined);
   const esmLoader = require('internal/process/esm_loader');
   const { pathToFileURL } = require('internal/url');
   const { hasUncaughtExceptionCaptureCallback } =

lib/internal/process/esm_loader.js

@@ -42,6 +42,9 @@ let calledInitialize = false;
 exports.initializeLoader = initializeLoader;
 async function initializeLoader() {
   assert(calledInitialize === false);
+  process.emitWarning(
+    'The ESM module loader is experimental.',
+    'ExperimentalWarning', undefined);
   calledInitialize = true;
   if (!userLoader)
     return;