Skip to content

esm: Unflag --experimental-modules #29866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

esm: Unflag --experimental-modules #29866

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1d2c187
esm: unflag --experimental-modules
guybedford Oct 11, 2019
31a2faa
fixup test
guybedford Nov 8, 2019
04bab86
pr feedback
guybedford Nov 9, 2019
dd1625c
fixup message tests
guybedford Nov 9, 2019
3ffdfd4
--experimental-modules for upcoming features
guybedford Nov 9, 2019
814a207
nit
guybedford Nov 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
--experimental-modules for upcoming features
  • Loading branch information
@guybedford
guybedford committed Nov 10, 2019
commit 3ffdfd42b46cf0bea66cf3e5c0f776dfe0f9a8d2
9 changes: 9 additions & 0 deletions doc/api/cli.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,14 @@ added: v12.9.0

Enable experimental JSON support for the ES Module loader.

### `--experimental-modules`
<!-- YAML
added: v8.5.0
-->

Enable latest experimental modules features (currently
`--experimental-conditional-exports` and `--experimental-self-resolve`).

### `--experimental-policy`
<!-- YAML
added: v11.8.0
Expand Down Expand Up @@ -1025,6 +1033,7 @@ Node.js options that are allowed are:
* `--experimental-conditional-exports`
* `--experimental-json-modules`
* `--experimental-loader`
* `--experimental-modules`
* `--experimental-policy`
* `--experimental-repl-await`
* `--experimental-report`
Expand Down
3 changes: 3 additions & 0 deletions doc/node.1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ Enable experimental support for "require" and "node" conditional export targets.
.It Fl -experimental-json-modules
Enable experimental JSON interop support for the ES Module loader.
.
.It Fl -experimental-modules
Enable experimental latest experimental modules features.
.
.It Fl -experimental-resolve-self
Enable experimental support for a package to load itself.
.
Expand Down
2 changes: 2 additions & 0 deletions src/node_options.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,8 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
&EnvironmentOptions::userland_loader,
kAllowedInEnvironment);
AddAlias("--loader", "--experimental-loader");
AddAlias("--experimental-modules", { "--experimental-conditional-exports",
"--experimental-resolve-self" });
AddOption("--experimental-conditional-exports",
"experimental support for conditional exports targets",
&EnvironmentOptions::experimental_conditional_exports,
Expand Down
3 changes: 1 addition & 2 deletions test/es-module/test-esm-exports.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// Flags: --experimental-resolve-self --experimental-conditional-exports

// Flags: --experimental-modules
import { mustCall } from '../common/index.mjs';
import { ok, deepStrictEqual, strictEqual } from 'assert';

Expand Down