Skip to content

module: change default resolver to not throw on unknown scheme #47824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 19, 2023
Merged

module: change default resolver to not throw on unknown scheme #47824

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
52d276e
module: change default resolver to not throw on unknown scheme
giltayar Apr 29, 2023
94afcae
fix lint errors
giltayar May 2, 2023
c87c78c
Update doc/api/esm.md
giltayar May 2, 2023
3df4003
added test for extensions, and simplified protocol test
giltayar May 3, 2023
f615248
remove fixtures by inlining them in the test
giltayar May 3, 2023
e4b4cdf
change load example to "import map" semantics
giltayar May 3, 2023
a387b9c
fix lint errors
giltayar May 3, 2023
88a4ce9
Update doc/api/esm.md to improve "import map" loader
giltayar May 4, 2023
b0eb1c0
Document resolution not failing on url protocol
giltayar May 5, 2023
98924dd
add some loader info to esm docs and change to "default resolver"
giltayar May 7, 2023
357e8db
esm.md fixed based on comments
giltayar May 9, 2023
2c7e695
fix expected error message
giltayar May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update doc/api/esm.md 
Co-authored-by: Geoffrey Booth <[email protected]>
  • Loading branch information
@giltayar @GeoffreyBooth
giltayar and GeoffreyBooth authored May 2, 2023
commit c87c78c16c7404d692e837ed1eeea487938f56bf
6 changes: 3 additions & 3 deletions doc/api/esm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,10 +1179,10 @@ loaded file.

#### Overriding loader
Copy link
Member

@GeoffreyBooth GeoffreyBooth May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this code? Can you add it to the examples in https://github.com/nodejs/loaders-test?

We should probably have an example that needs to use both resolve and load, so that we demonstrate how the two hooks work together. Ideally it would be as realistic a use case as possible.

Speaking of realistic examples, another “resolve-only” use case discussed in the design docs for the loaders API was to rewrite specifiers like lodash into URLs like https://esm.sh/lodash. Perhaps this might be a better example than this “overriding loader,” as it would presumably be a lot shorter of an example.

Copy link
Contributor Author

@giltayar giltayar May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this code? Can you add it to the examples in https://github.com/nodejs/loaders-test?

I have (in my repo that I link to in the issue), but I can definitely copy it to https://github.com/nodejs/loaders-test.

Speaking of realistic examples, another “resolve-only” use case discussed in the design docs for the loaders API was to rewrite specifiers like lodash into URLs like https://esm.sh/lodash

The example I gave is very realistic as it is a simplification of import maps, where you can map bare specifiers to specific files. I can definitely use your use-case, but I think in terms of complexity, they're roughly the same.

Copy link
Contributor Author

@giltayar giltayar May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this lands (hopefully...😊), I'll not only add this loader to the loaders-test, but also modify the http-loader and typescript-loader to not need resolvers.


The above two loaders hooked into the "load" phase of the module loader.
This loader hooks into the "resolution" phase. This loader reads an
The previous two loaders defined `load` hooks. This is an example of a loader
that does its work via the `resolve` hook. This loader reads an
`overrides.json` file that specifies which specifiers to override to another
url.
URL.

```js
// overriding-loader.js
Expand Down