Skip to content

module: change default resolver to not throw on unknown scheme #47824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 19, 2023
Merged

module: change default resolver to not throw on unknown scheme #47824

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
52d276e
module: change default resolver to not throw on unknown scheme
giltayar Apr 29, 2023
94afcae
fix lint errors
giltayar May 2, 2023
c87c78c
Update doc/api/esm.md
giltayar May 2, 2023
3df4003
added test for extensions, and simplified protocol test
giltayar May 3, 2023
f615248
remove fixtures by inlining them in the test
giltayar May 3, 2023
e4b4cdf
change load example to "import map" semantics
giltayar May 3, 2023
a387b9c
fix lint errors
giltayar May 3, 2023
88a4ce9
Update doc/api/esm.md to improve "import map" loader
giltayar May 4, 2023
b0eb1c0
Document resolution not failing on url protocol
giltayar May 5, 2023
98924dd
add some loader info to esm docs and change to "default resolver"
giltayar May 7, 2023
357e8db
esm.md fixed based on comments
giltayar May 9, 2023
2c7e695
fix expected error message
giltayar May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove fixtures by inlining them in the test
  • Loading branch information
@giltayar
giltayar committed May 3, 2023
commit f615248b81cfd6cd9222ab35ad89a34a326a4491
12 changes: 9 additions & 3 deletions test/es-module/test-esm-loader-default-resolver.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ describe('default resolver', () => {
'--no-warnings',
'--experimental-loader',
fixtures.fileURL('/es-module-loaders/byop-dummy-loader.mjs'),
fixtures.path('/es-module-loaders/byop-dummy-loader-main.mjs'),
'--input-type=module',
'--eval',
"import 'byop://1/index.mjs'"
]);
assert.strictEqual(code, 0);
assert.strictEqual(stdout.trim(), 'index.mjs!');
Expand All @@ -24,7 +26,9 @@ describe('default resolver', () => {
'--no-warnings',
'--experimental-loader',
fixtures.fileURL('/es-module-loaders/byop-dummy-loader.mjs'),
fixtures.path('/es-module-loaders/byop-dummy-loader-main2.mjs'),
'--input-type=module',
'--eval',
"import 'byop://1/index2.mjs'"
]);
assert.strictEqual(code, 0);
assert.strictEqual(stdout.trim(), '42');
Expand All @@ -37,7 +41,9 @@ describe('default resolver', () => {
'--no-warnings',
'--experimental-loader',
fixtures.fileURL('/es-module-loaders/byop-dummy-loader.mjs'),
fixtures.path('/es-module-loaders/byop-dummy-loader-main3.mjs'),
'--input-type=module',
'--eval',
"import 'byop://1/index.byoe'"
]);
assert.strictEqual(code, 0);
assert.strictEqual(stdout.trim(), 'index.byoe!');
Expand Down
1 change: 0 additions & 1 deletion test/fixtures/es-module-loaders/byop-dummy-loader-main.mjs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion test/fixtures/es-module-loaders/byop-dummy-loader-main2.mjs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion test/fixtures/es-module-loaders/byop-dummy-loader-main3.mjs
View file
Open in desktop

This file was deleted.