Skip to content

test_runner: add support for mocking setImmediate timer #49397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 31, 2023
Merged

test_runner: add support for mocking setImmediate timer #49397

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
41d7fc3
test_runner: add support for setImmediate
ErickWendel Aug 29, 2023
c1d70cc
add @ovflowd suggestion
ErickWendel Aug 29, 2023
4fbcd69
test: change mock callCount to common.mustCall
ErickWendel Aug 29, 2023
a8c1ede
test: explicit add mustcall 1 times
ErickWendel Aug 29, 2023
962e14a
test_runner: apply sugestions
ErickWendel Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test_runner: apply sugestions 
Co-authored-by: Jordan Harband <[email protected]>
Co-authored-by: Moshe Atlow <[email protected]>
  • Loading branch information
@ErickWendel @ljharb @MoLow
3 people committed Aug 30, 2023
commit 962e14a7d4018a0967b1c6cc29e911b8e20783d1
2 changes: 1 addition & 1 deletion doc/api/test.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1579,7 +1579,7 @@ added:
Enables timer mocking for the specified timers.

* `timers` {Array} An optional array containing the timers to mock.
The currently supported timer values are `'setInterval'`, `'setTimeout'`
The currently supported timer values are `'setInterval'`, `'setTimeout'`,
and `'setImmediate'`. If no value is provided, all timers (`'setInterval'`,
`'clearInterval'`, `'setTimeout'`, `'clearTimeout'`, `'setImmediate'`,
and `'clearImmediate'`) will be mocked by default.
Expand Down
1 change: 0 additions & 1 deletion lib/internal/test_runner/mock/mock_timers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ const SUPPORTED_TIMERS = ['setTimeout', 'setInterval', 'setImmediate'];
const TIMERS_DEFAULT_INTERVAL = {
__proto__: null,
setImmediate: -1,
nextTick: -2,
};

class MockTimers {
Expand Down