Skip to content

test_runner: add support for mocking setImmediate timer #49397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 31, 2023
Merged

test_runner: add support for mocking setImmediate timer #49397

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
41d7fc3
test_runner: add support for setImmediate
ErickWendel Aug 29, 2023
c1d70cc
add @ovflowd suggestion
ErickWendel Aug 29, 2023
4fbcd69
test: change mock callCount to common.mustCall
ErickWendel Aug 29, 2023
a8c1ede
test: explicit add mustcall 1 times
ErickWendel Aug 29, 2023
962e14a
test_runner: apply sugestions
ErickWendel Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: explicit add mustcall 1 times 
Signed-off-by: Erick Wendel <[email protected]>
  • Loading branch information
@ErickWendel
ErickWendel committed Aug 29, 2023
commit a8c1edeceb83d8b8edb903cb90e797299c2ff357
28 changes: 12 additions & 16 deletions test/parallel/test-runner-mock-timers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,39 +264,35 @@ describe('Mock Timers Test Suite', () => {

it('should advance in time and trigger timers when calling the .tick function', (t) => {
t.mock.timers.enable(['setImmediate']);
global.setImmediate(common.mustCall());
global.setImmediate(common.mustCall(1));
t.mock.timers.tick(0);
});

it('should execute in order if setImmediate is called multiple times', (t) => {
t.mock.timers.enable(['setImmediate']);
const order = [];
const fn1 = t.mock.fn(() => order.push('f1'));
const fn2 = t.mock.fn(() => order.push('f2'));
const fn1 = t.mock.fn(common.mustCall(() => order.push('f1'), 1));
const fn2 = t.mock.fn(common.mustCall(() => order.push('f2'), 1));

global.setImmediate(fn1);
global.setImmediate(fn2);

t.mock.timers.tick(0);

assert.strictEqual(fn1.mock.callCount(), 1);
assert.strictEqual(fn2.mock.callCount(), 1);
assert.deepStrictEqual(order, ['f1', 'f2']);
});

it('should execute setImmediate first if setTimeout was also called', (t) => {
t.mock.timers.enable(['setImmediate', 'setTimeout']);
const order = [];
const fn1 = t.mock.fn(() => order.push('f1'));
const fn2 = t.mock.fn(() => order.push('f2'));
const fn1 = t.mock.fn(common.mustCall(() => order.push('f1'), 1));
const fn2 = t.mock.fn(common.mustCall(() => order.push('f2'), 1));

global.setTimeout(fn2, 0);
global.setImmediate(fn1);

t.mock.timers.tick(100);

assert.strictEqual(fn1.mock.callCount(), 1);
assert.strictEqual(fn2.mock.callCount(), 1);
assert.deepStrictEqual(order, ['f1', 'f2']);
});
});
Expand Down Expand Up @@ -408,7 +404,7 @@ describe('Mock Timers Test Suite', () => {
nodeTimers.setImmediate(common.mustCall(() => {
assert.strictEqual(now - timeout, expected());
done();
}));
}, 1));
});

it('should work with the same params as the original setImmediate', (t) => {
Expand All @@ -432,15 +428,15 @@ describe('Mock Timers Test Suite', () => {

it('should advance in time and trigger timers when calling the .tick function', (t) => {
t.mock.timers.enable(['setImmediate']);
nodeTimers.setImmediate(common.mustCall());
nodeTimers.setImmediate(common.mustCall(1));
t.mock.timers.tick(0);
});

it('should execute in order if setImmediate is called multiple times', (t) => {
t.mock.timers.enable(['setImmediate']);
const order = [];
const fn1 = t.mock.fn(common.mustCall(() => order.push('f1')));
const fn2 = t.mock.fn(common.mustCall(() => order.push('f2')));
const fn1 = t.mock.fn(common.mustCall(() => order.push('f1'), 1));
const fn2 = t.mock.fn(common.mustCall(() => order.push('f2'), 1));

nodeTimers.setImmediate(fn1);
nodeTimers.setImmediate(fn2);
Expand All @@ -453,8 +449,8 @@ describe('Mock Timers Test Suite', () => {
it('should execute setImmediate first if setTimeout was also called', (t) => {
t.mock.timers.enable(['setImmediate', 'setTimeout']);
const order = [];
const fn1 = t.mock.fn(common.mustCall(() => order.push('f1')));
const fn2 = t.mock.fn(common.mustCall(() => order.push('f2')));
const fn1 = t.mock.fn(common.mustCall(() => order.push('f1'), 1));
const fn2 = t.mock.fn(common.mustCall(() => order.push('f2'), 1));

nodeTimers.setTimeout(fn2, 0);
nodeTimers.setImmediate(fn1);
Expand Down Expand Up @@ -724,7 +720,7 @@ describe('Mock Timers Test Suite', () => {
p.then(common.mustCall((result) => {
assert.strictEqual(result, undefined);
done();
}));
}, 1));
});

it('should work with the same params as the original timers/promises/setImmediate', async (t) => {
Expand Down