Skip to content

Conversation

@max-mapper
Copy link
Contributor

@Fishrock123
Copy link
Contributor

@maxogden Correct me if I'm wrong, but isn't this better covered by https://nodejs.org/dist/index.json?

@Fishrock123 Fishrock123 added the content Issues/pr concerning content label Sep 15, 2015
@Fishrock123
Copy link
Contributor

Perhaps we should link to that json on this page?

@max-mapper
Copy link
Contributor Author

@Fishrock123 the data you linked is that data that is used to render the table, so it's the same thing

@rvagg
Copy link
Member

rvagg commented Sep 15, 2015

@maxogden see also nodejs/build#151 which is related to your gist

@rvagg
Copy link
Member

rvagg commented Sep 15, 2015

lgtm, I quite like the idea of this number becoming part of user-base consciousness as it's pretty important

@fhemberger
Copy link
Contributor

Can someone please add a little note on the table, what "NODE_MODULE_VERSION" is supposed to mean? Have you checked the table layout on small screens as well?

@rvagg
Copy link
Member

rvagg commented Sep 19, 2015

we could just call it "modules version", that'd be consistent enough:

$ node -p process.versions
{ http_parser: '2.5.0',
  node: '4.1.0',
  v8: '4.5.103.33',
  uv: '1.7.4',
  zlib: '1.2.8',
  ares: '1.10.1-DEV',
  modules: '46',                         <————
  openssl: '1.0.2d' }

@rvagg
Copy link
Member

rvagg commented Sep 19, 2015

Or just "Modules", it seems confusing but with a footnote it might make sense:

‡ "Modules" refers to the ABI (application binary interface) version number of Node.js, used to determine which versions of Node.js compiled C++ add-on binaries can be loaded in to without needing to be re-compiled.

@fhemberger
Copy link
Contributor

@rvagg 👍

@Fishrock123
Copy link
Contributor

Rod's comment seems good.

@max-mapper
Copy link
Contributor Author

Updated:

screen shot 2015-09-19 at 9 47 26 am

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NODE_MODULE_VERSION.

Might render better. (Also: period.) :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fishrock123 the period is in the diff, not in the screenshot sorry. Heres what it looks like wrapped with a <code>:

screen shot 2015-09-19 at 10 09 59 am

And without (the current version in the branch now):

screen shot 2015-09-19 at 10 10 29 am

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better with <code> IMHO. Let's get this merged. ;)

@max-mapper
Copy link
Contributor Author

alright, updated. should be good to go

fhemberger added a commit that referenced this pull request Sep 19, 2015
add NODE_MODULE_VERSION column to the releases table
@fhemberger fhemberger merged commit 7b0ffaa into nodejs:master Sep 19, 2015
@fhemberger
Copy link
Contributor

Yaaay! Thank you! ^____^

@rvagg
Copy link
Member

rvagg commented Sep 21, 2015

great work! I love that this is first-class, thanks @maxogden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content Issues/pr concerning content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants