Skip to content

add NODE_MODULE_VERSION column to the releases table #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2015
Merged

add NODE_MODULE_VERSION column to the releases table #160

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73f7e0e
add NODE_MODULE_VERSION column to the releases table
max-mapper Sep 15, 2015
8a52c5d
rename column to modules and put description in footer
max-mapper Sep 19, 2015
0e54e73
wrap in code block
max-mapper Sep 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename column to modules and put description in footer
  • Loading branch information
@max-mapper
max-mapper committed Sep 19, 2015
commit 8a52c5dc19e85fa1a81eecfd3149fb5652e3e7d4
3 changes: 3 additions & 0 deletions layouts/css/page-modules/_download.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ td.download-table-last
> a
padding 0 10px

#modules-description
font-size: small

@media (max-width: 700px)
.download-hero ul
width auto
Expand Down
5 changes: 3 additions & 2 deletions layouts/download-releases.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<td>Date</td>
<td>V8</td>
<td>npm</td>
<td>NODE_MODULE_VERSION</td>
<td>Modules</td>
<td></td>
</tr>
</thead>
Expand All @@ -36,7 +36,7 @@
<td data-label="Date"><time>{{date}}</time></td>
<td data-label="V8">{{v8}}</td>
<td data-label="npm">{{npm}}</td>
<td data-label="NODE_MODULE_VERSION">{{modules}}</td>
<td data-label="Modules">{{modules}}</td>
<td class="download-table-last">
<a href="{{url}}">
{{i18n 'releases.downloads'}}
Expand All @@ -49,6 +49,7 @@
{{/project.versions}}
</tbody>
</table>
<p id="modules-description">{{modules}}</p>
</section>
</article>

Expand Down
1 change: 1 addition & 0 deletions locale/en/download/releases.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ layout: download-releases.hbs
title: Previous Releases
iojs:
intro: "Releases 1.x through 3.x were called \"io.js\" as they were part of the io.js fork. As of Node.js 4.0.0 the former release lines of io.js converged with Node.js 0.12.x into unified Node.js releases."
modules: "\"Modules\" refers to the ABI (application binary interface) version number of Node.js, used to determine which versions of Node.js compiled C++ add-on binaries can be loaded in to without needing to be re-compiled. This version number is also referred to as NODE_MODULE_VERSION."
Copy link
Contributor

@Fishrock123 Fishrock123 Sep 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NODE_MODULE_VERSION.

Might render better. (Also: period.) :)

Copy link
Contributor Author

@max-mapper max-mapper Sep 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fishrock123 the period is in the diff, not in the screenshot sorry. Heres what it looks like wrapped with a <code>:

screen shot 2015-09-19 at 10 09 59 am

And without (the current version in the branch now):

screen shot 2015-09-19 at 10 10 29 am

Copy link
Contributor

@fhemberger fhemberger Sep 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better with <code> IMHO. Let's get this merged. ;)

---