Update the list of global events

[lpinca]

Follow up of #614.
This updates events.md to fix the Spain region issue.

I've used my own API key for meetup.com and no API key for node-geocoder (it seems to work fine).

[ghost]

Travis build passed 👍

[fhemberger]

1. lat/lng coordinates for the following events were deleted. Was this intentional?
   • Chennai NodeSchool
   • Jakarta NodeSchool
   • NodeSchool Kanpur
   • Tabriz NodeSchool
   • Tehran NodeSchool
   • NodeSchool Tokyo
   • Chernivtsi NodeSchool
   • Dublin NodeSchool
   • Faro NodeSchool
   • Nodeschool Lodz
   • NodeSchool Madrid
   • Lyon NodeSchool
   • NodeSchool Strasbourg
   • NodeSchool Stuttgart
   • NodeSchool Vienna
   • NodeSchool Cleveland
   • NodeSchool: LA Edition
   • NodeSchool Manchester
   • NodeSchool Philadelphia
   • NodeSchool Raleigh-Durham
   • NodeSchool DC
   • NodeSchool Vancouver
   • Western Massachusetts NodeSchool
2. We should adjust the event script:
   • Collapse new lines in description texts. One entry added 390 empty new lines.
   • We don't show things like member count (which is also changing constantly), I vote for dropping at least this field to keep future diffs easier to handle.

[lpinca]

It wasn't intentional and I noticed the empty lines issue.
The scripts need indeed some love.

[lpinca]

I'll try to fix this later or tomorrow.

[lpinca]

The new line issue seems to be a bug in js-yaml:

const data = yaml.safeLoad(contents);
const dump = yaml.safeDump(data); // => unwanted new lines.

See nodeca/js-yaml#221, nodeca/js-yaml#222. Not sure what to do about it. Those issues seem to be fixed in master and it looks like that a new version of js-yaml will be released soon but the new dumper uses a sligtly different syntax so we will have a lof of diff noise.

Maybe it makes sense to rebuild events.md from scratch.

[fhemberger]

Hmm, in the meantime, how about something like description.replace(/\n{3,}/g, '\\n\\n')?

[lpinca]

@fhemberger I tried that, not so useful, the problem is that the major part of the new lines are added when data is dumped with yaml.dump(store).

We can probably work around that issue using the lineWidth option (e.g. setting it to something like 2000) but we will generate so much noise that it will be very hard to review the changes.

That's why I think it's probably better to regenerate events.md from scratch.

[lpinca]

I've updated the pr to work around the js-yaml issue with spurious new lines.
Now a line width is not enforced so yaml.dump() works as expected.

There is a lot of diff noise but I tried to make the review process a little "easier" by splitting the changes over multiple commits.

If we wait for the next version of js-yaml, 52f4895 can be removed.

[fhemberger]

Why not title.includes('mongodb')?

[lpinca]

Because there are some MongoDB+Node.js events.

[fhemberger]

Ah, ok. 👍

[lpinca]

There are also a lot of irrelevant events like Angular Ember etc but it's kinda hard to have ONLY relevant Node.js events. This a flaw in Meetup categories and topics.

[fhemberger]

I haven't run the scripts myself, but the overall changes look good to me.

@lpinca f974616, 650ddc7, 29ab04f and d4931de look like manual changes. Will they be overwritten the next time someone runs the script?

[lpinca]

They will be updated yes, but not deleted. New events will be added.
The purpose of 29ab04f is exactly to prevent it from being overwritten.

[fhemberger]

Great, thank you!

[lpinca]

@fhemberger I've added the requested comments, let me know if they should be changed/improved.

[fhemberger]

@lpinca LGTM! 👍