Skip to content

Conversation

@cdnadmin
Copy link
Contributor

Hey, y'all, simply wanted to add the Austin MEAN Stack Dev meetup in the North American list of meetups.

@ghost
Copy link

ghost commented May 27, 2016

LGTM. thanks for contributing!

@ghost ghost merged commit 0088e03 into nodejs:master May 27, 2016
@stevemao
Copy link
Contributor

I thought those were automatically generated?

@ghost
Copy link

ghost commented May 27, 2016

@stevemao what do you mean? is there a script for it somewhere?

@ghost
Copy link

ghost commented May 27, 2016

oh wait, do you mean pull-meetup.js?

@stevemao
Copy link
Contributor

I think so.

@ghost
Copy link

ghost commented May 27, 2016

actually, i retract that statement. the get-involved/events.md file doesn't look like it belongs in version control at all, it's way too big.

@lpinca
Copy link
Member

lpinca commented May 27, 2016

@tentakel yes, that is the script to pull the events. That one and pull-nodeschool.js populate get-involved/events.md. It was way bigger than it is now 😄 . See #625.

@cdnadmin
Copy link
Contributor Author

cdnadmin commented May 27, 2016

Sweet! Thx, everyone!

Why my approach? --> First, I just wanted to get our meetup in here ASAP. :-)

I did try using pull-meetup.js, but I noticed that when I ran it locally (used my own meetup API key of course), it firstly ran into an issue with MK not being in the country-map.js export object . i.e. new data from meeetup.com's API. Then, when I added MK (locally, just to test), pull-meetup.js added a whole bunch of other meetups, and other data, that I didn't want to muck around with, because I'm not sure what policy there is for this. So, I added our data directly, and PR'd it here.

Also, I know pull-meetup.js triggers off of meetups' having "nodeJs" as one of their configured topics, so I added it to ours, but, again, other data was being pulled in.

So, I opted for adding our meetup's data directly and submitting this PR.

Question, when do these pull files get executed to update the respective *.md files?

Thx again, y'all!

@cdnadmin cdnadmin deleted the add-atx-meanstack branch May 27, 2016 15:17
@lpinca
Copy link
Member

lpinca commented May 27, 2016

Question, when do these pull files get executed to update the respective *.md files?

Not sure, I think it's done manually now, pull request to add MK to the map is welcome :)

@cdnadmin
Copy link
Contributor Author

cdnadmin commented May 27, 2016

...pull request to add MK to the map is welcome :)

#762

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants