Block Bindings: Support Image block's caption attribute, remove <figcaption> if empty
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
force-pushed
the
try/simplify-block-bindings-replace-html
branch
2 times, most recently
from
b558a5a to
a18e435
Compare
3 tasks
Owner
Author
|
Closing in favor of WordPress#9702. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiment, based on WordPress#9469.
Explores "conditional" Block Bindings, using the example of the Image block's
captionattribute. The following cases need to be supported when that attribute is bound to a Block Bindings source:<figcaption>element is removed.<figcaption>element is added (with the caption set to the Block Bindings source value).save.jsto always include a<figcaption>-- even if thecaptionattribute is empty -- and running the logic from the case described directly above.Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.