Skip to content

Block Bindings: Support Image block's caption attribute, remove <figcaption> if empty #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ockham wants to merge 21 commits into from
Closed

Block Bindings: Support Image block's caption attribute, remove <figcaption> if empty #5

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
2d7b4f3
Introduce data provider to allow extending test coverage
ockham Aug 13, 2025
a137176
Add test coverage for Button block's text attribute
ockham Aug 13, 2025
83b3ae1
Block Bindings: Simplify replace_html() method
ockham Aug 13, 2025
15d619b
Add WP_Block_Bindings_Processor class
ockham Aug 18, 2025
9dc0aba
Use WP_Block_Bindings_Processor for block bindings
ockham Aug 18, 2025
d9132f8
Add kses back :/
ockham Aug 18, 2025
c011d25
WPCS
ockham Aug 18, 2025
9295227
Remove obsolete var
ockham Aug 18, 2025
3c3f908
Indentation
ockham Aug 18, 2025
c46300d
Return true upon success
ockham Aug 18, 2025
f528702
Add basic PHPDoc
ockham Aug 18, 2025
73efaa7
Add more PHPDoc
ockham Aug 19, 2025
d5798c1
Add basic test coverage
ockham Aug 19, 2025
26a0a29
Allow setting attributes
ockham Aug 19, 2025
0dbe235
Increase test coverage
ockham Aug 19, 2025
3b9eac6
Increase test coverage
ockham Aug 20, 2025
e98185e
Add more commentary and warnings
ockham Aug 20, 2025
1511528
Block Bindings: Support image caption attribute
ockham Aug 20, 2025
958603d
Block Bindings Processor: Add remove_node() method
ockham Aug 20, 2025
8841df4
Block Bindings: Remove empty nodes if rich-text attribute is empty
ockham Aug 20, 2025
693eb87
Add test coverage for node removal
ockham Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Block Bindings: Support image caption attribute
  • Loading branch information
@ockham
ockham committed Aug 20, 2025
commit 1511528eb02b65eec5f1a467c6fce779aada05a2
2 changes: 1 addition & 1 deletion src/wp-includes/class-wp-block.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class WP_Block {
private const BLOCK_BINDINGS_SUPPORTED_ATTRIBUTES = array(
'core/paragraph' => array( 'content' ),
'core/heading' => array( 'content' ),
'core/image' => array( 'id', 'url', 'title', 'alt' ),
'core/image' => array( 'id', 'url', 'title', 'alt', 'caption' ),
'core/button' => array( 'url', 'text', 'linkTarget', 'rel' ),
'core/post-date' => array( 'datetime' ),
);
Expand Down
10 changes: 10 additions & 0 deletions tests/phpunit/tests/block-bindings/render.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,16 @@ public function data_update_block_with_value_from_source() {
,
'<div class="wp-block-button"><a class="wp-block-button__link wp-element-button">test source value</a></div>',
),
'image block' => array(
'caption',
<<<HTML
<!-- wp:image {"id":66,"sizeSlug":"large","linkDestination":"none"} -->
<figure class="wp-block-image size-large"><img src="breakfast.jpg" alt="" class="wp-image-1"/><figcaption class="wp-element-caption">Breakfast at a <em>café</em> in Wrocław.</figcaption></figure>
<!-- /wp:image -->
HTML
,
'<figure class="wp-block-image size-large"><img src="breakfast.jpg" alt="" class="wp-image-1"/><figcaption class="wp-element-caption">test source value</figcaption></figure>'
)
);
}

Expand Down