test: fix perf-sidebar-reload via setTitle + annotate two pre-existin…

…g flakes

perf-sidebar-reload was using Playwright's `.fill()` followed by an
immediate `keyboard.press('Escape')`. That race is one we already
documented: `EditableTitle`'s Escape handler only sets
`isEditing=false`, and the commit is supposed to fire from the
input's onBlur as it unmounts — but the path is fragile enough that
the `/commit` POST silently never goes out. The sister `setTitle()`
helper uses `.type()` + a `waitForCommitOnCurrentResource` waiter
that blocks until the commit response actually lands. Switch to it.

After fix: passes solo in 3.8s.

Also annotate two more tests as `// FLAKY` in the same style as
`cb2297a4`:

  - `e2e.spec.ts:547 dialog`: trips a strict-mode violation when
    `test-prop`/`test-shortname` leak across runs of the suite.
    Per-test name suffix or a cleanup hook would fix it.

  - `JSONProp.spec.ts:7 create JSON prop`: depends on a class hosted
    on the public `atomicdata.dev` (a hard-coded `01k10mtpp...`
    subject). When the public server is slow or unreachable, the
    form fields never render and the test times out. Inline the
    class or host a local copy.

The remaining 4 of the 7 post-revert failures (`ontology`, `plugin`,
`sync:177`, `table-refresh:86`) were already annotated `// FLAKY` by
`cb2297a4`. No more regressions on this branch worth chasing.

browser/e2e/tests/JSONProp.spec.ts

@@ -4,6 +4,12 @@ import { before, newDrive, newResource, signIn } from './test-utils';
 test.describe('JSON prop', () => {
   test.beforeEach(before);
 
+  // FLAKY (local, intermittent): depends on a class hosted on the public
+  // `atomicdata.dev` (line 13: `01k10mtpp8fkkmsd6tkm9qrqyw/...`). When
+  // the public server is slow / unreachable, the form fields never
+  // render and `getByLabel('Name').fill(...)` times out at 10s.
+  // Investigation: inline the class definition or host a copy on the
+  // test atomic-server instead of crossing the internet.
   test('create JSON prop', async ({ page }) => {
     await signIn(page);
     await newDrive(page);

browser/e2e/tests/e2e.spec.ts

@@ -544,6 +544,14 @@ test.describe('data-browser', async () => {
     await expect(page.getByRole('heading', { name })).toBeVisible();
   });
 
+  // FLAKY (local, observed in suite re-runs): when the dev-drive is reused
+  // across tests in the same suite (e.g. a previous `dialog` run left
+  // `test-prop` and `test-shortname` resources), `getByRole('button', {
+  // name: 'test-prop', exact: true })` resolves to 2 elements and trips
+  // playwright's strict-mode check. Looks pre-existing — same pattern
+  // the `// FLAKY` block above this file already documents for the
+  // children-collection refresh race. Investigation: either add a per-
+  // test resource-name suffix or have `before()` clean up matching names.
   test('dialog', async ({ page }) => {
     await newResource('https://atomicdata.dev/classes/Class', page);
 

browser/e2e/tests/perf-sidebar-reload.spec.ts

@@ -19,7 +19,7 @@
  */
 
 import { test, expect } from '@playwright/test';
-import { before, editableTitle } from './test-utils';
+import { before, editableTitle, setTitle } from './test-utils';
 import { attachPerfSnapshot, resetPerfTrace } from './perf-attach';
 
 test.describe('perf: sidebar after reload', () => {
@@ -37,12 +37,13 @@ test.describe('perf: sidebar after reload', () => {
     await expect(editableTitle(page)).toBeVisible({ timeout: 10000 });
     const phaseA_ms = Date.now() - phaseA_start;
 
-    // Phase B: enter title + Escape → commit fires
+    // Phase B: enter title + Escape → commit fires. Use the `setTitle`
+    // helper rather than a raw `.fill()` + Escape so we get the
+    // built-in `waitForCommitOnCurrentResource` waiter — `.fill()`
+    // alone leaves the title save racing the input unmount, and we
+    // saw the commit POST silently skipped on local re-runs.
     const phaseB_start = Date.now();
-    await editableTitle(page).click();
-    await expect(editableTitle(page)).toHaveRole('textbox');
-    await editableTitle(page).fill('Perf Probe Doc');
-    await page.keyboard.press('Escape');
+    await setTitle(page, 'Perf Probe Doc');
 
     // Phase C: sidebar shows the doc title (this is the assertion that
     // flakes in dagger). Poll the DOM directly so we can distinguish