e2e: replace fixed waitForTimeouts with proper data/visibility waits

The replaced sleeps were guessing at how long async work would take
(commit-debounce-flush, dropdown mount, post-fill auto-submit, menu
unfurl). Each is now an explicit wait on the actual signal:

- After typing-edits: poll `pendingDirtyCount === 0` instead of a 1.5s/2s
  guess. The dirty queue settles to 0 once every keystroke has been ack'd
  by the server — that's the real "saved" signal.
- Before opening an invite URL in a new context: same `pendingDirtyCount`
  drain, instead of 200ms.
- After typing `@` in the RTE: wait for `rte-command-list` visibility
  instead of 500ms.
- Onboarding `verifySecret`: drop the 500ms before the URL assertion —
  `expect(page).toHaveURL` already polls for 10s, the auto-submit fires
  inside that window.
- `contextMenuClick`: wait for the menu item's visibility instead of
  guessing 100ms for unfurl.
- `tables.spec`: replace the two pre-reload "wait for save" sleeps with
  the same dirty-queue check.

These are the cases where the wait had a clear signal to bind to. Some
remaining sleeps (dblclick gap to defeat dblclick threshold, network-stack
warmup after `setOffline(false)`, debug-trace pacing) are intentional and
left in place.

browser/e2e/tests/documents.spec.ts

@@ -118,7 +118,11 @@ test.describe('documents', async () => {
     // Add a link to a folder via @ mention
     await page2.keyboard.press('Space');
     await page2.keyboard.type('@');
-    await page2.waitForTimeout(500);
+    // The RTE command list mounts asynchronously after `@` is typed.
+    // Wait for it instead of guessing a fixed delay.
+    await expect(page2.getByTestId('rte-command-list')).toBeVisible({
+      timeout: 10000,
+    });
     await page2.keyboard.type(folderTitle, { delay: 50 });
     await expect(
       page2.getByTestId('rte-command-list').getByText(folderTitle),

browser/e2e/tests/e2e.spec.ts

@@ -107,7 +107,15 @@ test.describe('data-browser', async () => {
     );
     expect(inviteUrl).not.toBeFalsy();
 
-    await page.waitForTimeout(200);
+    // The invite resource needs to be persisted server-side before the
+    // invitee opens its URL — otherwise the server returns 404. Wait for
+    // the dirty queue to drain rather than guessing a fixed 200ms.
+    await page.waitForFunction(
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      () => (window as any).store?.getSyncStatus?.().pendingDirtyCount === 0,
+      undefined,
+      { timeout: 10000 },
+    );
 
     // Open invite
     const page3 = await openNewSubjectWindow(browser, inviteUrl as string);
@@ -253,8 +261,16 @@ test.describe('data-browser', async () => {
       await editableTitle(page).type(letter, { delay: Math.random() * 300 });
     }
 
-    // Wait long enough for the final debounce (100ms) + network round-trip.
-    await page.waitForTimeout(1500);
+    // Wait for the debounced save to drain into the server before exiting
+    // edit mode. The dirty queue settles to 0 once every accumulated keystroke
+    // has been ack'd — that's the actual "typing finished saving" signal,
+    // and it returns immediately if we're already idle.
+    await page.waitForFunction(
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      () => (window as any).store?.getSyncStatus?.().pendingDirtyCount === 0,
+      undefined,
+      { timeout: 10000 },
+    );
     await page.keyboard.press('Escape');
 
     await expect(

browser/e2e/tests/onboarding.spec.ts

@@ -63,10 +63,8 @@ test.describe('onboarding', () => {
     // Paste the secret we read earlier (clipboard may not work after signout)
     await page.getByLabel('Enter your Agent Secret').fill(secret!);
 
-    // Wait for auto-verify to trigger
-    await page.waitForTimeout(500);
-
-    // Should auto-verify and navigate to the drive
+    // The form auto-submits ~150ms after fill (GettingStartedFlow useEffect).
+    // The URL assertion below already polls — no separate sleep needed.
     await expect(page).toHaveURL(/did(?:%3A|:)ad(?:%3A|:)/, { timeout: 10000 });
 
     // Open a NEW BROWSER CONTEXT (fresh, as if on a completely different computer)

browser/e2e/tests/tables.spec.ts

@@ -187,9 +187,16 @@ test.describe('tables', async () => {
       page.getByRole('button', { name: selectColumnName }),
     ).toBeVisible();
 
-    // Wait for all pending commits to be flushed before reload.
-    // 'networkidle' is unreliable on SPAs with persistent WebSocket connections.
-    await page.waitForTimeout(2000);
+    // Wait for all pending commits to drain into the server before reload.
+    // 'networkidle' is unreliable on SPAs with persistent WebSocket
+    // connections (commit subscriptions, the open WS, etc.). The dirty
+    // queue is the actual saved-to-server signal.
+    await page.waitForFunction(
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      () => (window as any).store?.getSyncStatus?.().pendingDirtyCount === 0,
+      undefined,
+      { timeout: 10000 },
+    );
     await page.reload();
     await expect(
       page.getByRole('button', { name: selectColumnName }),
@@ -308,8 +315,13 @@ test.describe('tables', async () => {
     // Exit edit mode
     await page.keyboard.press('Escape');
 
-    // Wait for all debounced saves to complete
-    await page.waitForTimeout(2000);
+    // Wait for all debounced saves to drain into the server.
+    await page.waitForFunction(
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      () => (window as any).store?.getSyncStatus?.().pendingDirtyCount === 0,
+      undefined,
+      { timeout: 10000 },
+    );
 
     // Verify all values are displayed correctly before refresh
     for (const value of values) {

browser/e2e/tests/test-utils.ts

@@ -634,8 +634,10 @@ export async function clickSidebarItem(text: string, page: Page) {
 /** Click an item from the main, visible context menu */
 export async function contextMenuClick(text: string, page: Page) {
   await page.click(contextMenu);
-  await page.waitForTimeout(100);
-  await page.getByTestId(`menu-item-${text}`).click();
+  // Wait for the menu item to mount instead of guessing 100ms.
+  const item = page.getByTestId(`menu-item-${text}`);
+  await item.waitFor({ state: 'visible', timeout: 5000 });
+  await item.click();
 }
 
 export const anyValue = Symbol('any');