This repository was archived by the owner on Oct 11, 2024. It is now read-only.
fix: Refactor l1 cost and mint computations #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
clabby
approved these changes
Sep 5, 2023
clabby
left a comment
clabby
left a comment
There was a problem hiding this comment.
LGTM; One comment about the underflow throwing an error rather than silently saturating.
refcell
force-pushed
the
refcell/refactors
branch
from
be171fe to
6b868b3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the l1 cost computation and mint value account updates into
EVMImplfunctions.