-
Notifications
You must be signed in to change notification settings - Fork 966
feat: Optimism execution changes #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabby
commented
Sep 4, 2023
clabby
commented
Sep 4, 2023
rakita
reviewed
Sep 5, 2023
fe9bc08 to
a31c31c
Compare
fix: Flatten optimism hoisted tx fields
fix: Refactor l1 cost and mint computations
feat: Refactor gas usage
chore: upstream sync
Merge REVM upgrades
chore: upstream sync
Contributor
|
Would really really appreciate another round of review here |
Introduce call return handler
feat: Handler
Oprevm merge to main repo
remove USE_GAS from handlers
fix: quick no-conflict upstream sync
rakita
approved these changes
Sep 27, 2023
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! One nit comment.
Co-authored-by: rakita <[email protected]>
sync: quick upstream sync - no conflicts
fix: param mutability
Contributor
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements Optimism's execution changes into
revmbehind theoptimismfeature flag. These changes enable native Optimism execution changes inop-reth,foundry,anvil, and other projects building on top ofrevm.Goal
With the
optimismfeature flag enabled, a new configuration option is exposed that allows for enabling Optimism's execution changes at runtime. This is so that tools such as Foundry can swap between regular Ethereum execution and Optimism execution as needed (i.e. for multichain fork testing).revm's regular logic should be unaltered if either theoptimismcfg option isfalseor theoptimismfeature flag is not enabled.New Hardforks
Bedrock(Ethereum Base:Merge)Regolith(Base:Bedrock)TODO
TxEnvfields withinrevm-primitives.Somemint field.optimismconfiguration flag is enabled.L1Blockcontract.Future
optimismcfg option add when theoptimismfeature flag is enabled but theoptimismcfg option is not? For example, in order forfoundryto swap betweenoptimismandethereumexecution modes, the regular release build will have to enable theoptimismfeature flag onrevm. Does the runtime branching significantly slow down execution for the majority of tests which are not on OP?