fix: rm NodeJS type from core, rm react core peer #681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
toddbaert
commented
Nov 22, 2023
toddbaert
commented
- remove a NodeJS type from core module which needs to be platform agnostic
- remove core peer dep from react sdk, which gets core through web-sdk
* remove a NodeJS type from core module which needs to be platform agnostic * remove core peer dep from react sdk, which gets core through web-sdk Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
Nov 22, 2023
beeme1mr
approved these changes
Nov 22, 2023
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
Nov 22, 2023
lukas-reining
approved these changes
Nov 27, 2023
Member
lukas-reining
left a comment
lukas-reining
left a comment
There was a problem hiding this comment.
Looks good to me!
PlatformEventEmitter seems like a good way of avoiding the bundling issue as the EventEmitter interface will also be stable enough.
This was referenced Nov 27, 2023
toddbaert
pushed a commit
that referenced
this pull request
Nov 27, 2023
🤖 I have created a release *beep* *boop* --- ## [0.0.20](core-v0.0.19...core-v0.0.20) (2023-11-27) ### 🐛 Bug Fixes * add Provider Not Ready Error ([#680](#680)) ([b0054f9](b0054f9)) * rm NodeJS type from core, rm react core peer ([#681](#681)) ([09ff7b4](09ff7b4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: openfeature-peer-update-bot <[email protected]> Co-authored-by: openfeature-peer-update-bot <[email protected]>
toddbaert
pushed a commit
that referenced
this pull request
Nov 27, 2023
🤖 I have created a release *beep* *boop* --- ## [0.0.5-experimental](react-sdk-v0.0.4-experimental...react-sdk-v0.0.5-experimental) (2023-11-27) ### 🐛 Bug Fixes * rm NodeJS type from core, rm react core peer ([#681](#681)) ([09ff7b4](09ff7b4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
This was referenced Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.