fix: ts error regarding NodeJS.Timer in frontend #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukas-reining
changed the title
toddbaert
reviewed
Nov 22, 2023
toddbaert
approved these changes
Nov 22, 2023
Member
|
Thanks! There's actually a similar issue in |
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
fix/node-types-in-frontend
branch
from
01e0a15 to
9f7c0ce
Compare
toddbaert
changed the title
Member
|
signing off and merging |
beeme1mr
pushed a commit
that referenced
this pull request
Nov 30, 2023
🤖 I have created a release *beep* *boop* --- ## [0.13.0](v0.12.1...v0.13.0) (2023-11-30) ### 🐛 Bug Fixes * **deps:** update dependency @harnessio/ff-nodejs-server-sdk to v1.3.4 ([e8c6ff5](e8c6ff5)) * **deps:** update dependency @harnessio/ff-nodejs-server-sdk to v1.3.7 ([8bf8d55](8bf8d55)) * ts error regarding NodeJS.Timer in frontend ([#254](#254)) ([d4d0a38](d4d0a38)) ### ✨ New Features * update demo app and documentation ([#255](#255)) ([eaa770d](eaa770d)) ### 🧹 Chore * **deps:** update dependency @babel/preset-react to v7.23.3 ([7ee6e8a](7ee6e8a)) * **deps:** update dependency @mui/material to v5.14.13 ([fe2a386](fe2a386)) * **deps:** update dependency @mui/material to v5.14.17 ([c535a07](c535a07)) * **deps:** update dependency core-js to v3.33.2 ([658e2dc](658e2dc)) * **deps:** update ghcr.io/open-feature/flagd docker tag to v0.6.7 ([a61a286](a61a286)) * **deps:** update ghcr.io/open-feature/flagd docker tag to v0.6.8 ([5d1f9d0](5d1f9d0)) * **deps:** update prom/prometheus docker tag to v2.47.1 ([93ea09d](93ea09d)) * **deps:** update prom/prometheus docker tag to v2.47.2 ([795ebfd](795ebfd)) * **deps:** update types ([18bf413](18bf413)) * **deps:** update types ([84d7f6c](84d7f6c)) * fix package-log.json ([f6a02d1](f6a02d1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
@toddbaert as said, this fixes the typescript error where Node.JS Timers are returned from setInterval.
Related Issues
Notes
Follow-up Tasks
How to test