[Instrumentation.AspNet] Include some attributes in sampling process #3151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:instrumentation.aspnet.telemetryhttpmodule
Kielek
force-pushed
the
aspnet-startactivityattributes
branch
from
68c6e14 to
4c8d942
Compare
Member
Author
|
@open-telemetry/dotnet-contrib-approvers, AspNet part is ready to review. I need to fix |
src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/CHANGELOG.md
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/TelemetryHttpModuleOptions.cs
Show resolved
Hide resolved
drops check to OperationName, it is not used by OpenTelemetry
It is done to add url attribute on startup -> it depends on IConfiguration not available on IIS side
Kielek
force-pushed
the
aspnet-startactivityattributes
branch
from
4c8d942 to
50a5dd8
Compare
github-actions
bot
added
the
comp:instrumentation.wcf
Member
Author
|
@repl-chris, it will be great if you can review at least WCF changes, as you have developed initial version. |
martincostello
approved these changes
Sep 29, 2025
alanwest
approved these changes
Sep 30, 2025
rajkumar-rangaraj
approved these changes
Sep 30, 2025
2 tasks
Kielek
added a commit
to ysolomchenko/opentelemetry-dotnet-instrumentation
that referenced
this pull request
Oct 16, 2025
System.Web.Http nor System.Web.Mvc are not loaded on OWIN. System.Web seems the most suitable alternative. Previously Activity was created by the TelemetryModule. Now it was pushed to the Instrumentation library. Handles changes from: open-telemetry/opentelemetry-dotnet-contrib#3151
3 tasks
Kielek
added a commit
to ysolomchenko/opentelemetry-dotnet-instrumentation
that referenced
this pull request
Oct 20, 2025
System.Web.Http nor System.Web.Mvc are not loaded on OWIN. System.Web seems the most suitable alternative. Previously Activity was created by the TelemetryModule. Now it was pushed to the Instrumentation library. Handles changes from: open-telemetry/opentelemetry-dotnet-contrib#3151
Kielek
added a commit
to open-telemetry/opentelemetry-dotnet-instrumentation
that referenced
this pull request
Oct 22, 2025
…beta.1/beta.2 (#4524) Bump OpenTelemetry.Instrumentation.AspNet/Wcf 1.13.0-beta.1/beta.2 (#4524) * Fix AspNet on OWIN instrumentation System.Web.Http nor System.Web.Mvc are not loaded on OWIN. System.Web seems the most suitable alternative. Previously Activity was created by the TelemetryModule. Now it was pushed to the Instrumentation library. Handles changes from: open-telemetry/opentelemetry-dotnet-contrib#3151 * Owin tests - ensure that client spanId is propagated to AspNet instrumentation Co-authored-by: Piotr Kiełkowicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2909
Changes
Goal - make following attributes available on startup:
http.request.method,server.address,server.port,url.scheme,url.path,user_agent.original,url.query.Side effect: breaking changes in IIS module.
It is not responsible for creating activity. It delegates it to the instrumentation package.
2 reasons for this design:
While reviewing you can check commit-by-commit towards this implementation. The last one is the big commit only.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes