Skip to content

[Instrumentation.AspNet] Include some attributes in sampling process #3151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kielek merged 16 commits into from
Oct 1, 2025
Merged

[Instrumentation.AspNet] Include some attributes in sampling process #3151

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a30b5f7
Cleanup - initiate TagList in AqlActivityHelper
Kielek Sep 17, 2025
21b172d
Switch to TagList
Kielek Sep 17, 2025
5bfbe25
Move http.request.method to start time
Kielek Sep 17, 2025
fa0fb7e
Move server.address to start time
Kielek Sep 18, 2025
474067e
Move server.port to start time
Kielek Sep 18, 2025
8e40d9f
Move url.scheme to start time
Kielek Sep 18, 2025
5b9bcc5
Move user.agent_original to start time
Kielek Sep 18, 2025
45a5dc6
set activity name during start
Kielek Sep 18, 2025
b9e3bac
Activity is created by instrumentation
Kielek Sep 26, 2025
4f33ba5
Update CHANGELOG
Kielek Sep 26, 2025
50a5dd8
Adjust WCF instrumentation to ASP.NET changes
Kielek Sep 29, 2025
5a9a9aa
PR feedback - changelog wording
Kielek Sep 29, 2025
db60663
PR feedback - comment about the Activity creation
Kielek Sep 29, 2025
4252de9
PR feedback - changelog alphabetical order
Kielek Sep 29, 2025
fda26f6
dotnet format
Kielek Sep 29, 2025
f1be3a0
Merge branch 'main' into aspnet-startactivityattributes
Kielek Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Cleanup - initiate TagList in AqlActivityHelper
  • Loading branch information
@Kielek
Kielek committed Sep 29, 2025
commit a30b5f77f44a6b16832a88032cf834a3cc2523c5
2 changes: 1 addition & 1 deletion src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlActivitySourceHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public static TagList GetTagListFromConnectionInfo(string? dataSource, string? d
? MicrosoftSqlServerDbSystemName
: MicrosoftSqlServerDbSystem;

var tags = new TagList { };
TagList tags = default;

if (options.EmitOldAttributes)
{
Expand Down