Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1135 +/- ##
==========================================
- Coverage 77.28% 77.23% -0.05%
==========================================
Files 220 220
Lines 6260 6269 +9
==========================================
+ Hits 4838 4842 +4
- Misses 1422 1427 +5
|
eddynaka
approved these changes
Aug 21, 2020
CodeBlanch
reviewed
Aug 22, 2020
| /// shutdown completed or timed out. | ||
| /// </summary> | ||
| public virtual void Shutdown() | ||
| /// <param name="timeoutMillis"> |
Member
There was a problem hiding this comment.
nit: Should we spell it out fully timeoutMilliseconds?
Member
Author
There was a problem hiding this comment.
That name is coming from the spec.
@cijothomas if we want be C# idiomatic, I will use timeoutMilliseconds across the entire repo (current many places are already using the timeoutMillis convention from the spec.
Member
Author
There was a problem hiding this comment.
I've changed all places to use timeoutMilliseconds.
CodeBlanch
approved these changes
Aug 22, 2020
Member
CodeBlanch
left a comment
CodeBlanch
left a comment
There was a problem hiding this comment.
LGTM, just the one nit on timeoutMillis name.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR concludes #1078.
Changes
ShutdownandForceFlush.For significant contributions please make sure you have completed the following items: