Skip to content

Refactor exporter - step 10 #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodeBlanch merged 6 commits into from
Aug 22, 2020
Merged

Refactor exporter - step 10 #1135

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cd9c9f5
make Shutdown/Flush sync
reyang Aug 21, 2020
4872682
calculate remaining time
reyang Aug 21, 2020
6184e9e
fix doc
reyang Aug 21, 2020
6060124
update changelog
reyang Aug 21, 2020
682fc94
s/timeoutMillis/timeoutMilliseconds/g
reyang Aug 22, 2020
f214261
Merge branch 'master' into reyang/exporter10
CodeBlanch Aug 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix doc
  • Loading branch information
@reyang
reyang committed Aug 21, 2020
commit 6184e9e98b2a3262b37face67af3722a829f2c02
6 changes: 2 additions & 4 deletions docs/trace/building-your-own-sampler/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,11 @@
critical code path.

```csharp
class MySampler : Sampler
internal class MySampler : Sampler
{
public override SamplingResult ShouldSample(in SamplingParameters samplingParameters)
{
var shouldSample = true;

return new SamplingResult(shouldSample);
return new SamplingResult(SamplingDecision.RecordAndSampled);
}
}
```