[sdk] Allow / in metric instrument names
#4882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the regex in `MeterProviderBuilderSdk.cs` to allow metric instrument names to contain `/` characters. This is in response to the issue raised in [open-telemetry#4887](open-telemetry#4877). Now, metric names like `my_metric/environment/database` can be used. Corresponding changes are also made to the tests and CHANGELOG.md.
reyang
reviewed
Sep 25, 2023
Co-authored-by: Reiley Yang <[email protected]>
reyang
approved these changes
Sep 25, 2023
vishweshbankwar
approved these changes
Sep 25, 2023
Member
|
@tombiddulph Could you please resolve the conflicts. Thanks! |
CodeBlanch
reviewed
Sep 25, 2023
cijothomas
approved these changes
Sep 25, 2023
Member
|
Thanks @tombiddulph ! |
Codecov Report
@@ Coverage Diff @@
## main #4882 +/- ##
==========================================
- Coverage 83.15% 82.94% -0.22%
==========================================
Files 294 294
Lines 12188 12188
==========================================
- Hits 10135 10109 -26
- Misses 2053 2079 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
CodeBlanch
added
the
pkg:OpenTelemetry
CodeBlanch
changed the title
/ in metric instrument names/ in metric instrument names
Kielek
approved these changes
Sep 25, 2023
Yun-Ting
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4877
Design discussion issue #
Changes
Updates the regex in
MeterProviderBuilderSdk.csto allow metric instrument names to contain/characters. This is in response to the issue raised in #4887. Now, metric names likemy_metric/environment/databasecan be used. Corresponding changes are also made to the tests and CHANGELOG.md.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes