Batching activity processor #697
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
requested review from
SergeyKanzhelev,
bruno-garcia,
cijothomas,
discostu105,
lmolkova and
pjanotti
as code owners
32 tasks
cijothomas
reviewed
May 25, 2020
alanwest
reviewed
May 25, 2020
pjanotti
approved these changes
May 27, 2020
Contributor
pjanotti
left a comment
pjanotti
left a comment
There was a problem hiding this comment.
LGTM. I have two comments but I think they should be addressed separately and right now are lower priority.
…ry/opentelemetry-dotnet into batching-activity-processor * 'batching-activity-processor' of github.com:open-telemetry/opentelemetry-dotnet: Catch exceptions in flush timer and write to EventSource (#696)
Contributor
|
@MikeGoldsmith tests are failing after the last merge, did you have a chance to look at the failures? |
Member
Author
|
Yeah, I think it's related to what @CodeBlanch saw in one of his recently PRs where he needed to add IDisposeable to the object returned from |
Member
|
@rajkumar-rangaraj wanted to take this PR. @MikeGoldsmith please let us know if you are okay! |
1 task
Member
|
Closing in favor on #755 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a batching activity exporter, including tests.
Note: Some of the tests are failing, looks to be because the Activities created in the two utility methods at the top of the file are null. I'll continue to investigate but also happy for review to see if someone can see the problem.
Checklist