Skip to content

Batching activity processor #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MikeGoldsmith wants to merge 9 commits into from
Closed

Batching activity processor #697

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ca19aca
rename TestExporter to TestSpanExporter
MikeGoldsmith May 24, 2020
27a0b34
add batching activity processor
MikeGoldsmith May 24, 2020
437c464
add tests for batching activity processor
MikeGoldsmith May 24, 2020
42dcfeb
Merge branch 'master' into batching-activity-processor
cijothomas May 25, 2020
74e623d
use Task.Run to start worker
MikeGoldsmith May 27, 2020
5231e3e
reuse list for exporting batch
MikeGoldsmith May 27, 2020
5bd8692
fix typo - astivities to activities
MikeGoldsmith May 27, 2020
1c03a50
Merge branch 'batching-activity-processor' of github.com:open-telemet…
MikeGoldsmith May 27, 2020
54fdfe0
Merge branch 'master' into batching-activity-processor
cijothomas Jun 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use Task.Run to start worker
  • Loading branch information
@MikeGoldsmith
MikeGoldsmith committed May 27, 2020
commit 74e623dfc7ae33a171808c6414ca32e9ce550b4a
3 changes: 1 addition & 2 deletions src/OpenTelemetry/Trace/Export/BatchingActivityProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,8 @@ public BatchingActivityProcessor(ActivityExporter exporter, int maxQueueSize, Ti
this.exportQueue = new ConcurrentQueue<Activity>();

// worker task that will last for lifetime of processor.
// No need to specify long running - it is useless if any async calls are made internally.
// Threads are also useless as exporter tasks run in thread pool threads.
Task.Factory.StartNew(s => this.Worker((CancellationToken)s), this.cts.Token);
Task.Run(() => this.Worker(this.cts.Token), this.cts.Token);
}

/// <inheritdoc/>
Expand Down