Skip to content

Conversation

@rauno56
Copy link
Member

@rauno56 rauno56 commented Sep 21, 2022

Which problem is this PR solving?

Restify instrumentation required some mainenance.

There was a previous effort by @jscherer92: #1133
I built on top of that PR and left what Justin had done(thanks!) intact so the attribution should be intact in the end.

Fixes #1132
Closes #1133

Short description of the changes

  1. updated the main package version
  2. removed type exports
  3. fixed tests for newer versions
  4. added TAV
  5. turned off tests on node@18: fix: support node v18 restify/node-restify#1906

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@rauno56 rauno56 added pkg:instrumentation-restify priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies labels Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #1191 (52f0650) into main (6920a55) will decrease coverage by 0.47%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1191      +/-   ##
==========================================
- Coverage   96.08%   95.60%   -0.48%     
==========================================
  Files          14       20       +6     
  Lines         893     1070     +177     
  Branches      191      221      +30     
==========================================
+ Hits          858     1023     +165     
- Misses         35       47      +12     
Impacted Files Coverage Δ
...opentelemetry-instrumentation-restify/src/types.ts 100.00% <ø> (ø)
...telemetry-instrumentation-restify/src/constants.ts 100.00% <100.00%> (ø)
...try-instrumentation-restify/src/instrumentation.ts 89.32% <100.00%> (ø)
...nstrumentation-restify/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 98.03% <0.00%> (ø)
...opentelemetry-instrumentation-restify/src/utils.ts 100.00% <0.00%> (ø)

@rauno56 rauno56 marked this pull request as ready for review September 21, 2022 17:52
@rauno56 rauno56 requested a review from a team September 21, 2022 17:52
@rauno56 rauno56 merged commit 8873057 into open-telemetry:main Sep 23, 2022
@rauno56 rauno56 deleted the fix/avoid-type-imports branch September 23, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:instrumentation-restify priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TS2430: Interface 'Request' incorrectly extends interface 'IncomingMessage' when using getNodeAutoInstrumentations

4 participants