Skip to content

test: fix tests for restify >=5 #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Sep 23, 2022
Merged

test: fix tests for restify >=5 #1191

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
a0294aa
fix(restify): upgrade package to fix type problem
jscherer92 Aug 30, 2022
f6b409b
Merge branch 'main' into fix-restify
jscherer92 Sep 1, 2022
2872079
fix(restify): updated so types are not leaking through #1132
jscherer92 Sep 2, 2022
f8fc832
Merge branch 'main' into fix-restify
jscherer92 Sep 2, 2022
2cd3f88
fix(restify): lint fix
jscherer92 Sep 2, 2022
df1877d
fix(restify): final fix up for linter
jscherer92 Sep 2, 2022
6f47c24
style: avoid checking in manually edited package.json
rauno56 Sep 20, 2022
2cba0d6
Merge branch 'main' into fix/avoid-type-imports
rauno56 Sep 21, 2022
937ae41
test: require restify again for every test
rauno56 Sep 20, 2022
d468ce5
test: differenciate between thorwing and failing gracefully
rauno56 Sep 20, 2022
7b4289a
test: use custom error
rauno56 Sep 20, 2022
98eb1d5
feat: support restify@5
rauno56 Sep 20, 2022
9cd7900
feat: support restify@7
rauno56 Sep 20, 2022
6f40f94
feat: support restify@8
rauno56 Sep 20, 2022
837b84d
test: cleanup
rauno56 Sep 20, 2022
4ae5ad4
test: anyfy arguments on the anonymous handler
rauno56 Sep 20, 2022
3f1baf4
chore: add tav + update supported versions
rauno56 Sep 20, 2022
73cb491
fix: turn off tests on node@18 which is not supported for restify
rauno56 Sep 20, 2022
c90812c
Merge branch 'main' into fix/avoid-type-imports
rauno56 Sep 22, 2022
3535375
refactor: remove the import to after setting up instrumentation
rauno56 Sep 20, 2022
0661303
Merge remote-tracking branch 'upstream/main' into fix/avoid-type-imports
rauno56 Sep 22, 2022
52f0650
Merge branch 'main' into fix/avoid-type-imports
rauno56 Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: turn off tests on node@18 which is not supported for restify
  • Loading branch information
@rauno56
rauno56 committed Sep 21, 2022
commit 73cb49149ba16adbd9181abe534fb6edd13db99d
2 changes: 1 addition & 1 deletion .github/workflows/unit-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ jobs:
matrix:
node: ["14", "16", "18"]
include:
# tests fail on node@18, incompatibility with nock?
- node: "18"
lerna-extra-args: >-
--ignore @opentelemetry/resource-detector-alibaba-cloud
--ignore @opentelemetry/instrumentation-fastify
--ignore @opentelemetry/instrumentation-restify
runs-on: ubuntu-latest
services:
memcached:
Expand Down