switch to false-by-default config vars to avoid surprises with undefi…

…ned values

See https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/sdk-environment-variables.md#boolean-value
Suggestion from blumamir.

plugins/node/opentelemetry-instrumentation-bunyan/README.md

@@ -17,7 +17,7 @@ npm install --save @opentelemetry/instrumentation-bunyan
 
 ## Supported Versions
 
-- `^1.0.0`
+- `bunyan@^1.0.0`
 
 ## Usage
 
@@ -54,7 +54,7 @@ Creation of a Bunyan Logger will automatically add a [Bunyan stream](https://git
 
 If the OpenTelemetry SDK is not configured with a Logger provider, then this added stream will be a no-op.
 
-The logs bridge can be disabled with the `enableLogsBridge: false` option.
+The logs bridge can be disabled with the `disableLogsBridge: true` option.
 
 ### Log injection
 
@@ -74,15 +74,15 @@ After adding these fields, the optional `logHook` is called to allow injecting a
 ```
 
 When no span context is active or the span context is invalid, injection is skipped.
-Log injection can be disabled with the `enableInjection: false` option.
+Log injection can be disabled with the `disableInjection: true` option.
 
 ### Bunyan instrumentation options
 
-| Option             | Type              | Description |
-| ------------------ | ----------------- | ----------- |
-| `enableLogsBridge` | `boolean`         | Whether [logs bridging](#logs-bridge) is enabled. Default `true`. |
-| `enableInjection`  | `boolean`         | Whether [log injection](#log-injection) is enabled. Default `true`. |
-| `logHook`          | `LogHookFunction` | An option hook to inject additional context to a log record after span context has been added. This requires `enableInjection` to be true. |
+| Option              | Type              | Description |
+| ------------------- | ----------------- | ----------- |
+| `disableLogsBridge` | `boolean`         | Whether to disable [logs bridging](#logs-bridge). Default `false`. |
+| `disableInjection`  | `boolean`         | Whether to disable [log injection](#log-injection). Default `false`. |
+| `logHook`           | `LogHookFunction` | An option hook to inject additional context to a log record after span context has been added. This requires `disableInjection` to be false. |
 
 ## Useful links
 

plugins/node/opentelemetry-instrumentation-bunyan/src/instrumentation.ts

@@ -27,8 +27,8 @@ import { OpenTelemetryBunyanStream } from './OpenTelemetryBunyanStream';
 import type * as BunyanLogger from 'bunyan';
 
 const DEFAULT_CONFIG: BunyanInstrumentationConfig = {
-  enableLogsBridge: true,
-  enableInjection: true,
+  disableLogsBridge: false,
+  disableInjection: false,
 };
 
 export class BunyanInstrumentation extends InstrumentationBase<
@@ -114,7 +114,7 @@ export class BunyanInstrumentation extends InstrumentationBase<
       const instrumentation = this;
       return function patchedEmit(this: BunyanLogger, ...args: unknown[]) {
         const config = instrumentation.getConfig();
-        if (!instrumentation.isEnabled() || !config.enableInjection) {
+        if (!instrumentation.isEnabled() || config.disableInjection) {
           return original.apply(this, args);
         }
 
@@ -153,7 +153,7 @@ export class BunyanInstrumentation extends InstrumentationBase<
 
   private _addStream(logger: any) {
     const config: BunyanInstrumentationConfig = this.getConfig();
-    if (!this.isEnabled() || !config.enableLogsBridge) {
+    if (!this.isEnabled() || config.disableLogsBridge) {
       return;
     }
     this._diag.debug('Adding OpenTelemetryBunyanStream to logger');

plugins/node/opentelemetry-instrumentation-bunyan/src/types.ts

@@ -22,23 +22,23 @@ export type LogHookFunction = (span: Span, record: Record<string, any>) => void;
 
 export interface BunyanInstrumentationConfig extends InstrumentationConfig {
   /**
-   * Whether to enable the automatic sending of log records to the OpenTelemetry
-   * Logs Bridge API.
-   * @default true
+   * Whether to disable the automatic sending of log records to the
+   * OpenTelemetry Logs Bridge API.
+   * @default false
    */
-  enableLogsBridge?: boolean;
+  disableLogsBridge?: boolean;
 
   /**
-   * Whether to enable the injection of data such as trace-context fields into
+   * Whether to disable the injection of data such as trace-context fields into
    * log output.
-   * @default true
+   * @default false
    */
-  enableInjection?: boolean;
+  disableInjection?: boolean;
 
   /**
    * A function that allows injecting additional fields in log records. It is
    * called, as `logHook(span, record)`, for each log record emitted in a valid
-   * span context. It requires `enableInjection` to be true.
+   * span context. It requires `disableInjection` to be false.
    */
   logHook?: LogHookFunction;
 }

plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts

@@ -157,9 +157,9 @@ describe('BunyanInstrumentation', () => {
       });
     });
 
-    it('does not inject or call logHook if enableInjection=false', () => {
+    it('does not inject or call logHook if disableInjection=true', () => {
       instrumentation.setConfig({
-        enableInjection: false,
+        disableInjection: true,
         logHook: (_span, record) => {
           record['resource.service.name'] = 'test-service';
         },
@@ -268,10 +268,10 @@ describe('BunyanInstrumentation', () => {
       assert.strictEqual(rec.severityText, undefined);
     });
 
-    it('does not emit to the Logs Bridge API if enableLogsBridge=false', () => {
-      instrumentation.setConfig({ enableLogsBridge: false });
+    it('does not emit to the Logs Bridge API if disableLogsBridge=true', () => {
+      instrumentation.setConfig({ disableLogsBridge: true });
 
-      // Changing `enableLogsBridge` only has an impact on Loggers created
+      // Changing `disableLogsBridge` only has an impact on Loggers created
       // *after* it is set. So we cannot test with the `log` created in
       // `beforeEach()` above.
       log = Logger.createLogger({ name: 'test-logger-name', stream });