disableLogsBridge -> disableLogSending

Avoid using 'bridge' terminology at suggestion from specs that the Bridge API is an internal detail.

plugins/node/opentelemetry-instrumentation-bunyan/README.md

@@ -3,7 +3,7 @@
 [![NPM Published Version][npm-img]][npm-url]
 [![Apache License][license-image]][license-image]
 
-This module provides automatic instrumentation of the [`bunyan`](https://www.npmjs.com/package/bunyan) module to inject trace-context into Bunyan log records (Log correlation) and to bridge Bunyan logging to the OpenTelemetry Logging SDK. It may be loaded using the [`@opentelemetry/sdk-trace-node`](https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-sdk-trace-node) package and is included in the [`@opentelemetry/auto-instrumentations-node`](https://www.npmjs.com/package/@opentelemetry/auto-instrumentations-node) bundle.
+This module provides automatic instrumentation of the [`bunyan`](https://www.npmjs.com/package/bunyan) module to inject trace-context into Bunyan log records (log correlation) and to send Bunyan logging to the OpenTelemetry Logging SDK (log sending). It may be loaded using the [`@opentelemetry/sdk-trace-node`](https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-sdk-trace-node) package and is included in the [`@opentelemetry/auto-instrumentations-node`](https://www.npmjs.com/package/@opentelemetry/auto-instrumentations-node) bundle.
 
 If total installation size is not constrained, it is recommended to use the [`@opentelemetry/auto-instrumentations-node`](https://www.npmjs.com/package/@opentelemetry/auto-instrumentations-node) bundle with [@opentelemetry/sdk-node](`https://www.npmjs.com/package/@opentelemetry/sdk-node`) for the most seamless instrumentation experience.
 
@@ -39,7 +39,7 @@ const logger = bunyan.createLogger({name: 'example'});
 
 logger.info('hi');
 // 1. Log records will be sent to the SDK-registered log record processor, if any.
-//    This is called "bridging".
+//    This is called "log sending".
 
 const tracer = api.trace.getTracer('example');
 tracer.startActiveSpan('manual-span', span => {
@@ -50,13 +50,13 @@ tracer.startActiveSpan('manual-span', span => {
 })
 ```
 
-### Logs Bridge
+### Log sending
 
-Creation of a Bunyan Logger will automatically add a [Bunyan stream](https://github.com/trentm/node-bunyan#streams) that sends log records to the OpenTelemetry Logs Bridge API. The OpenTelemetry SDK can be configured to handle those records -- for example, sending them on to an OpenTelemetry collector for log archiving and processing. The example above shows a minimal configuration that emits OpenTelemetry log records to the console for debugging.
+Creation of a Bunyan Logger will automatically add a [Bunyan stream](https://github.com/trentm/node-bunyan#streams) that sends log records to the OpenTelemetry Logs SDK. The OpenTelemetry SDK can be configured to handle those records -- for example, sending them on to an OpenTelemetry collector for log archiving and processing. The example above shows a minimal configuration that emits OpenTelemetry log records to the console for debugging.
 
 If the OpenTelemetry SDK is not configured with a Logger provider, then this added stream will be a no-op.
 
-The logs bridge can be disabled with the `disableLogsBridge: true` option.
+Log sending can be disabled with the `disableLogSending: true` option.
 
 ### Log correlation
 
@@ -85,16 +85,16 @@ Log injection can be disabled with the `disableLogCorrelation: true` option.
 
 | Option                  | Type              | Description |
 | ----------------------- | ----------------- | ----------- |
-| `disableLogsBridge`     | `boolean`         | Whether to disable [logs bridging](#logs-bridge). Default `false`. |
+| `disableLogSending`     | `boolean`         | Whether to disable [log sending](#log-sending). Default `false`. |
 | `disableLogCorrelation` | `boolean`         | Whether to disable [log correlation](#log-correlation). Default `false`. |
 | `logHook`               | `LogHookFunction` | An option hook to inject additional context to a log record after trace-context has been added. This requires `disableLogCorrelation` to be false. |
 
 ### Using OpenTelemetryBunyanStream without instrumentation
 
-This package exports the Bunyan stream class that is used to bridge to the
-OpenTelemetry Logs Bridge API. It can be used directly when configuring a
-Bunyan logger if one is not using the `BunyanInstrumentation` for whatever
-reason. For example:
+This package exports the Bunyan stream class that is used to send records to the
+OpenTelemetry Logs SDK. It can be used directly when configuring a Bunyan logger
+if one is not using the `BunyanInstrumentation` for whatever reason. For
+example:
 
 ```js
 const { OpenTelemetryBunyanStream } = require('@opentelemetry/instrumentation-bunyan');

plugins/node/opentelemetry-instrumentation-bunyan/examples/README.md

@@ -63,17 +63,17 @@ $ node -r ./telemetry.js app.js
 }
 ```
 
-There are two separate Bunyan instrumentation features. The first, called
-"log correlation", is that Bunyan log records emitted in the context of a tracing
+There are two separate Bunyan instrumentation features. The first, called "log
+correlation", is that Bunyan log records emitted in the context of a tracing
 span will include `trace_id` and `span_id` fields that can be used for
 correlating with collected tracing data.
 
-The second, called "logs bridging", is that a [Bunyan
+The second, called "log sending", is that a [Bunyan
 stream](https://github.com/trentm/node-bunyan#streams) is automatically added
 to created Loggers that will send every log record to the OpenTelemetry Logs
-Bridge API. This means that if the OpenTelemetry SDK has been configured with
-a Logger Provider, it will receive them. (If the OpenTelemetry SDK is not
-configured for this, then the added Bunyan stream will be a no-op.)
+SDK. This means that if the OpenTelemetry SDK has been configured with a Logger
+Provider, it will receive them. (If the OpenTelemetry SDK is not configured for
+this, then the added Bunyan stream will be a no-op.)
 
 # Resource attributes
 

plugins/node/opentelemetry-instrumentation-bunyan/src/OpenTelemetryBunyanStream.ts

@@ -97,7 +97,7 @@ function severityNumberFromBunyanLevel(lvl: number) {
 }
 
 /**
- * A Bunyan stream for sending log records to the OpenTelemetry Logs Bridge API.
+ * A Bunyan stream for sending log records to the OpenTelemetry Logs SDK.
  */
 export class OpenTelemetryBunyanStream {
   private _otelLogger: Logger;
@@ -130,17 +130,16 @@ export class OpenTelemetryBunyanStream {
    *   the _emit wrapper.
    */
   write(rec: Record<string, any>) {
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     const {
       time,
       level,
       msg,
-      v,
-      hostname,
-      pid,
-      trace_id,
-      span_id,
-      trace_flags,
+      v, // eslint-disable-line @typescript-eslint/no-unused-vars
+      hostname, // eslint-disable-line @typescript-eslint/no-unused-vars
+      pid, // eslint-disable-line @typescript-eslint/no-unused-vars
+      trace_id, // eslint-disable-line @typescript-eslint/no-unused-vars
+      span_id, // eslint-disable-line @typescript-eslint/no-unused-vars
+      trace_flags, // eslint-disable-line @typescript-eslint/no-unused-vars
       ...fields
     } = rec;
     let timestamp = undefined;

plugins/node/opentelemetry-instrumentation-bunyan/src/instrumentation.ts

@@ -27,7 +27,7 @@ import { OpenTelemetryBunyanStream } from './OpenTelemetryBunyanStream';
 import type * as BunyanLogger from 'bunyan';
 
 const DEFAULT_CONFIG: BunyanInstrumentationConfig = {
-  disableLogsBridge: false,
+  disableLogSending: false,
   disableLogCorrelation: false,
 };
 
@@ -153,7 +153,7 @@ export class BunyanInstrumentation extends InstrumentationBase<
 
   private _addStream(logger: any) {
     const config: BunyanInstrumentationConfig = this.getConfig();
-    if (!this.isEnabled() || config.disableLogsBridge) {
+    if (!this.isEnabled() || config.disableLogSending) {
       return;
     }
     this._diag.debug('Adding OpenTelemetryBunyanStream to logger');

plugins/node/opentelemetry-instrumentation-bunyan/src/types.ts

@@ -23,10 +23,10 @@ export type LogHookFunction = (span: Span, record: Record<string, any>) => void;
 export interface BunyanInstrumentationConfig extends InstrumentationConfig {
   /**
    * Whether to disable the automatic sending of log records to the
-   * OpenTelemetry Logs Bridge API.
+   * OpenTelemetry Logs SDK.
    * @default false
    */
-  disableLogsBridge?: boolean;
+  disableLogSending?: boolean;
 
   /**
    * Whether to disable the injection trace-context fields, and possibly other

plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts

@@ -175,13 +175,13 @@ describe('BunyanInstrumentation', () => {
         assert.strictEqual(
           memExporter.getFinishedLogRecords().length,
           1,
-          'Logs Bridge still works'
+          'Log sending still works'
         );
         span.end();
       });
     });
 
-    it('emits log records to Logs Bridge API', () => {
+    it('emits log records to Logs SDK', () => {
       const logRecords = memExporter.getFinishedLogRecords();
 
       // levels
@@ -265,10 +265,10 @@ describe('BunyanInstrumentation', () => {
       assert.strictEqual(rec.severityText, undefined);
     });
 
-    it('does not emit to the Logs Bridge API if disableLogsBridge=true', () => {
-      instrumentation.setConfig({ disableLogsBridge: true });
+    it('does not emit to the Logs SDK if disableLogSending=true', () => {
+      instrumentation.setConfig({ disableLogSending: true });
 
-      // Changing `disableLogsBridge` only has an impact on Loggers created
+      // Changing `disableLogSending` only has an impact on Loggers created
       // *after* it is set. So we cannot test with the `log` created in
       // `beforeEach()` above.
       log = Logger.createLogger({ name: 'test-logger-name', stream });
@@ -288,7 +288,7 @@ describe('BunyanInstrumentation', () => {
       });
     });
 
-    it('emits to the Logs Bridge API with `new Logger(...)`', () => {
+    it('emits to the Logs SDK with `new Logger(...)`', () => {
       log = new Logger({ name: 'test-logger-name', stream });
       log.info('foo');
 
@@ -304,7 +304,7 @@ describe('BunyanInstrumentation', () => {
       assert.strictEqual(rec.attributes.aProperty, 'bar');
     });
 
-    it('emits to the Logs Bridge API with `Logger(...)`', () => {
+    it('emits to the Logs SDK with `Logger(...)`', () => {
       log = Logger({ name: 'test-logger-name', stream });
       log.info('foo');
 
@@ -367,7 +367,7 @@ describe('BunyanInstrumentation', () => {
       });
     });
 
-    it('does not emit to the Logs Bridge API', () => {
+    it('does not emit to the Logs SDK', () => {
       tracer.startActiveSpan('abc', span => {
         log.info('foo');
         assert.strictEqual(memExporter.getFinishedLogRecords().length, 0);