Skip to content

fix(plugin-ioredis): end span on response from the server and set span status according to response #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
obecny merged 22 commits into from
Jan 28, 2021
Merged

fix(plugin-ioredis): end span on response from the server and set span status according to response #239

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
cbdbd41
feat(plugin-ioredis): enahnce response handling
Nov 2, 2020
8faabe8
fix: add forgotten changes
Nov 2, 2020
b205e1c
style: fix lint
Nov 2, 2020
7a2a754
chore: remove reponseHook from PR
Nov 3, 2020
4a93f81
fix: remove unused import for build to pass
Nov 3, 2020
74c053f
chore: lint
Nov 3, 2020
11d48a2
Merge branch 'master' into ioredis-response
blumamir Nov 15, 2020
5eca6f9
style: set span error with ternary
Nov 15, 2020
2fc255f
Merge branch 'ioredis-response' of https://github.com/blumamir/opente…
Nov 15, 2020
1d72751
style: fix lint
Nov 15, 2020
38a3818
Merge branch 'master' into ioredis-response
blumamir Dec 10, 2020
a636f73
Merge branch 'master' into ioredis-response
obecny Dec 14, 2020
d376006
style: fix lint
Dec 14, 2020
8ddea04
Merge remote-tracking branch 'upstream/master' into ioredis-response
Jan 19, 2021
8a9ba4a
chore: fix lint
Jan 19, 2021
c8537ec
revert: lint change to graphql file
Jan 19, 2021
3f711a7
Merge branch 'master' into ioredis-response
Jan 21, 2021
c219444
Merge branch 'master' into ioredis-response
Jan 25, 2021
80e6c00
Merge branch 'master' into ioredis-response
Jan 27, 2021
c92e0ef
test(plugin-ioredis): make new test compatible with v0.15.0
Jan 27, 2021
ba2d4df
fix(plugin-ioredis): recordException on span when server returns error
Jan 28, 2021
dcfcd54
fix: correct type for events in assertSpan
Jan 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: lint
  • Loading branch information
Amir Blum committed Nov 3, 2020
commit 74c053fa4f1f537fd4712bea23cdae46656d54a4
7 changes: 1 addition & 6 deletions plugins/node/opentelemetry-plugin-ioredis/test/ioredis.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,7 @@
* limitations under the License.
*/

import {
CanonicalCode,
context,
SpanKind,
Status,
} from '@opentelemetry/api';
import { CanonicalCode, context, SpanKind, Status } from '@opentelemetry/api';
import { NoopLogger } from '@opentelemetry/core';
import { NodeTracerProvider } from '@opentelemetry/node';
import { AsyncHooksContextManager } from '@opentelemetry/context-async-hooks';
Expand Down