fix: add forgotten changes

plugins/node/opentelemetry-plugin-ioredis/README.md

@@ -49,6 +49,7 @@ IORedis plugin has few options available to choose from. You can set the followi
 | Options | Type | Description |
 | ------- | ---- | ----------- |
 | `dbStatementSerializer` | `DbStatementSerializer` | IORedis plugin will serialize db.statement using the specified function. |
+| `responseHook` | `RedisResponseCustomAttributeFunction` | Function for adding custom attributes on db response |
 
 #### Custom db.statement Serializer
 The plugin serializes the whole command into a Span attribute called `db.statement`. The standard serialization format is `{cmdName} {cmdArgs.join(',')}`.

plugins/node/opentelemetry-plugin-ioredis/package.json

@@ -6,7 +6,7 @@
   "types": "build/src/index.d.ts",
   "repository": "open-telemetry/opentelemetry-js",
   "scripts": {
-    "test": "nyc ts-mocha -p tsconfig.json 'test/**/*.test.ts' -g 'should call responseHook when set in config'",
+    "test": "nyc ts-mocha -p tsconfig.json 'test/**/*.test.ts'",
     "test:debug": "cross-env RUN_REDIS_TESTS_LOCAL=true ts-mocha --inspect-brk --no-timeouts -p tsconfig.json 'test/**/*.test.ts'",
     "test:local": "cross-env RUN_REDIS_TESTS_LOCAL=true npm run test",
     "tdd": "npm run test -- --watch-extensions ts --watch",

plugins/node/opentelemetry-plugin-ioredis/test/ioredis.test.ts

@@ -597,22 +597,45 @@ describe('ioredis', () => {
 
     describe('Instrumenting with a custom responseHook', () => {
 
-      before(() => {
+      it(`should call responseHook when set in config`, async () => {
         plugin.disable();
         const config: IoredisPluginConfig = {
           responseHook: (span: Span, cmdName: string, cmdArgs: Array<string | Buffer | number>, response: any) => {
-            console.log(cmdName);
+            assert.strictEqual(cmdName, 'incr');
+            // the command is 'incr' on a key which does not exist, thus it increase 0 by 1 and respond 1
+            assert.strictEqual(response, 1);
+            span.setAttribute('attribute key from hook', 'custom value from hook');
           },
         };
         plugin.enable(ioredis, provider, new NoopLogger(), config);
+
+        const span = provider
+          .getTracer('ioredis-test')
+          .startSpan('test span');
+        await provider.getTracer('ioredis-test').withSpan(span, async () => {
+          await client.incr('new-key');
+          const endedSpans = memoryExporter.getFinishedSpans();
+          assert.strictEqual(endedSpans.length, 1);
+          assert.strictEqual(endedSpans[0].attributes['attribute key from hook'], 'custom value from hook');
+        });
       });
 
-      it(`should call responseHook when set in config`, async () => {
+      it(`should call ignore responseHook which throws`, async () => {
+        plugin.disable();
+        const config: IoredisPluginConfig = {
+          responseHook: (span: Span, cmdName: string, cmdArgs: Array<string | Buffer | number>, response: any) => {
+            throw Error('error thrown in responseHook');
+          },
+        };
+        plugin.enable(ioredis, provider, new NoopLogger(), config);
+
         const span = provider
           .getTracer('ioredis-test')
           .startSpan('test span');
         await provider.getTracer('ioredis-test').withSpan(span, async () => {
           await client.incr('new-key');
+          const endedSpans = memoryExporter.getFinishedSpans();
+          assert.strictEqual(endedSpans.length, 1);
         });
       });