fix(user-interaction): event listeners have wrong this when listening for bubbled events#643
Merged
dyladan merged 6 commits intoopen-telemetry:mainfrom Aug 31, 2021
Merged
Conversation
… for bubbled events
Codecov Report
@@ Coverage Diff @@
## main #643 +/- ##
=======================================
Coverage 96.68% 96.68%
=======================================
Files 13 13
Lines 634 634
Branches 124 124
=======================================
Hits 613 613
Misses 21 21 |
johnbley
approved these changes
Aug 26, 2021
Member
johnbley
left a comment
There was a problem hiding this comment.
🤭 ... I should have made the tests better when I reworked the event listener instrumentation.
Member
|
I was going to merge this but then saw you're still pushing changes. Is this good to merge? |
Contributor
Author
|
Yep |
MSNev
approved these changes
Aug 30, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
thisinside event listeners gets changed toevent.target, which is incorrect when listening to bubbled events (click on a child element)see: https://codesandbox.io/s/inspiring-bartik-6bc3y?file=/src/index.js
Short description of the changes
Use
thisthe event listener is actually called with