Skip to content

fix(user-interaction): event listeners have wrong this when listening for bubbled events #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dyladan merged 6 commits into from
Aug 31, 2021
Merged

fix(user-interaction): event listeners have wrong this when listening for bubbled events #643

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cf70bcb
fix(user-interaction): event listeners have wrong this when listening…
t2t2 Aug 26, 2021
96a3881
Merge branch 'main' into event-target-this
t2t2 Aug 26, 2021
86517cb
Merge branch 'main' into event-target-this
t2t2 Aug 27, 2021
3077123
Also fix this when span isn't generated
t2t2 Aug 27, 2021
0c21d38
Merge branch 'main' into event-target-this
dyladan Aug 27, 2021
f684015
Merge branch 'main' into event-target-this
dyladan Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Also fix this when span isn't generated
  • Loading branch information
@t2t2
t2t2 committed Aug 27, 2021
commit 3077123cd2b18c341cbbb07ff291d0452794701e
2 changes: 1 addition & 1 deletion plugins/web/opentelemetry-instrumentation-user-interaction/src/instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ export class UserInteractionInstrumentation extends InstrumentationBase<unknown>
}
);
} else {
return plugin._invokeListener(listener, target, args);
return plugin._invokeListener(listener, this, args);
}
};
if (plugin.addPatchedListener(this, type, listener, patchedListener)) {
Expand Down