-
Notifications
You must be signed in to change notification settings - Fork 986
feat(sdk-metrics-base): distinguish between Sum and Gauge in MetricData #3079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
legendecas
merged 13 commits into
open-telemetry:main
from
dynatrace-oss-contrib:add-monotonic-flag
Jul 19, 2022
Merged
feat(sdk-metrics-base): distinguish between Sum and Gauge in MetricData #3079
legendecas
merged 13 commits into
open-telemetry:main
from
dynatrace-oss-contrib:add-monotonic-flag
Jul 19, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3079 +/- ##
==========================================
+ Coverage 92.66% 93.08% +0.42%
==========================================
Files 173 188 +15
Lines 5518 6248 +730
Branches 1171 1313 +142
==========================================
+ Hits 5113 5816 +703
- Misses 405 432 +27
|
058910a to
09294f3
Compare
legendecas
reviewed
Jul 8, 2022
Member
legendecas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great change! Overall LGTM. Just a few suggestions on testing.
experimental/packages/opentelemetry-exporter-prometheus/test/PrometheusSerializer.test.ts
Show resolved
Hide resolved
experimental/packages/opentelemetry-sdk-metrics-base/test/Instruments.test.ts
Show resolved
Hide resolved
f923764 to
1a442db
Compare
dyladan
reviewed
Jul 18, 2022
experimental/packages/opentelemetry-sdk-metrics-base/src/export/MetricData.ts
Outdated
Show resolved
Hide resolved
dyladan
approved these changes
Jul 19, 2022
legendecas
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
We do not distinguish between
SumandGaugeinMetricData. This complicates development of third-party exporters, which are required to rely onInstrumentType, which due to differentAggregationscan be confusing and therefore error-prone.This PR adds
SumDataPointandGaugeDataPointas a replacement forSingularDataPoint, and includesisMonotonicinSumDataPoint, and updates exporters in this repo accordingly.Fixes #3063
Short description of the changes
Type of change
DataPointType.SINGULARHow Has This Been Tested?
Checklist: