Skip to content

feat(sdk-metrics-base): distinguish between Sum and Gauge in MetricData #3079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
legendecas merged 13 commits into from
Jul 19, 2022
Merged

feat(sdk-metrics-base): distinguish between Sum and Gauge in MetricData #3079

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
dde1007
feature(sdk-metrics-base): distinguish between Sum and Gauge in Metri…
pichlermarc Jul 6, 2022
a4e7acd
feat(sdk-metrics-base): fix test.
pichlermarc Jul 7, 2022
09294f3
fix(changelog): add changelog entry.
pichlermarc Jul 7, 2022
2a530f8
feat(prometheus-serializer): add test for gauge serialization.
pichlermarc Jul 8, 2022
0291a65
feat(sdk-metrics-base): add assertions for isMonotonic in Instrument …
pichlermarc Jul 8, 2022
2b40e9f
feat(otlp-transformer): add test-cases for non-monotonic sums.
pichlermarc Jul 8, 2022
1a442db
feat(prometheus-exporter): add test-cases for gauges.
pichlermarc Jul 8, 2022
0a01324
Merge remote-tracking branch 'upstream/main' into add-monotonic-flag
pichlermarc Jul 12, 2022
560ba74
Merge remote-tracking branch 'upstream/main' into add-monotonic-flag
pichlermarc Jul 18, 2022
3e2ca28
Merge branch 'main' into add-monotonic-flag
pichlermarc Jul 18, 2022
d9de8d3
fix(sdk-metrics-base): remove DataPointType.SINGULAR
pichlermarc Jul 19, 2022
e920c78
fix(changelog): add more details about breaking changes.
pichlermarc Jul 19, 2022
ac7d6b5
Merge branch 'main' into add-monotonic-flag
pichlermarc Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(sdk-metrics-base): add assertions for isMonotonic in Instrument … 
…tests.
  • Loading branch information
@pichlermarc
pichlermarc committed Jul 8, 2022
commit 0291a654eaac263421c5b221c26742c9c7ff2b04
13 changes: 12 additions & 1 deletion experimental/packages/opentelemetry-sdk-metrics-base/test/Instruments.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ describe('Instruments', () => {
valueType: ValueType.INT,
},
dataPointType: DataPointType.SUM,
isMonotonic: true,
dataPoints: [
{
attributes: {},
Expand All @@ -100,6 +101,7 @@ describe('Instruments', () => {
counter.add(-1.1);
await validateExport(cumulativeReader, {
dataPointType: DataPointType.SUM,
isMonotonic: true,
dataPoints: [
{
attributes: {},
Expand All @@ -126,6 +128,7 @@ describe('Instruments', () => {
counter.add(1.2, { foo: 'bar' });
await validateExport(cumulativeReader, {
dataPointType: DataPointType.SUM,
isMonotonic: true,
dataPoints: [
{
attributes: {},
Expand All @@ -142,6 +145,7 @@ describe('Instruments', () => {
counter.add(-1.1);
await validateExport(cumulativeReader, {
dataPointType: DataPointType.SUM,
isMonotonic: true,
dataPoints: [
{
attributes: {},
Expand Down Expand Up @@ -200,6 +204,7 @@ describe('Instruments', () => {
valueType: ValueType.INT,
},
dataPointType: DataPointType.SUM,
isMonotonic: false,
dataPoints: [
{
attributes: {},
Expand All @@ -225,6 +230,7 @@ describe('Instruments', () => {
upDownCounter.add(1.1, { foo: 'bar' });
await validateExport(deltaReader, {
dataPointType: DataPointType.SUM,
isMonotonic: false,
dataPoints: [
{
attributes: {},
Expand Down Expand Up @@ -489,6 +495,7 @@ describe('Instruments', () => {

await validateExport(cumulativeReader, {
dataPointType: DataPointType.SUM,
isMonotonic: false,
dataPoints: [
{
attributes: {},
Expand All @@ -502,6 +509,7 @@ describe('Instruments', () => {
});
await validateExport(cumulativeReader, {
dataPointType: DataPointType.SUM,
isMonotonic: false,
dataPoints: [
{
attributes: {},
Expand Down Expand Up @@ -544,6 +552,7 @@ describe('Instruments', () => {

await validateExport(cumulativeReader, {
dataPointType: DataPointType.SUM,
isMonotonic: false,
dataPoints: [
{
attributes: {},
Expand All @@ -557,6 +566,7 @@ describe('Instruments', () => {
});
await validateExport(cumulativeReader, {
dataPointType: DataPointType.SUM,
isMonotonic: false,
dataPoints: [
{
attributes: {},
Expand Down Expand Up @@ -667,8 +677,9 @@ interface ValidateMetricData {
resource?: Resource;
instrumentationScope?: InstrumentationScope;
descriptor?: InstrumentDescriptor;
dataPointType?: DataPointType,
dataPointType?: DataPointType;
dataPoints?: Partial<DataPoint<number | Partial<Histogram>>>[];
isMonotonic?: boolean;
}

async function validateExport(reader: MetricReader, expected: ValidateMetricData) {
Expand Down