Skip to content

Conversation

@dyladan
Copy link
Member

@dyladan dyladan commented Oct 19, 2022

Because of the way lerna links peer dependencies, the big release depends on the API package being released first. This should fix the compilation issue.

@dyladan dyladan requested a review from a team October 19, 2022 15:58
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #3348 (c68a81f) into main (d808e29) will decrease coverage by 0.72%.
The diff coverage is n/a.

❗ Current head c68a81f differs from pull request most recent head 5ccb3e8. Consider uploading reports for the commit 5ccb3e8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3348      +/-   ##
==========================================
- Coverage   93.40%   92.68%   -0.73%     
==========================================
  Files         243      237       -6     
  Lines        7374     6921     -453     
  Branches     1527     1443      -84     
==========================================
- Hits         6888     6415     -473     
- Misses        486      506      +20     
Impacted Files Coverage Δ
api-metrics/src/NoopMeter.ts 97.36% <ø> (ø)
api-metrics/src/NoopMeterProvider.ts 100.00% <ø> (ø)
api-metrics/src/api/metrics.ts 87.50% <ø> (ø)
api-metrics/src/internal/global-utils.ts 90.90% <ø> (ø)
api-metrics/src/internal/semver.ts 97.61% <ø> (ø)
api-metrics/src/platform/node/globalThis.ts 100.00% <ø> (ø)
api-metrics/src/types/Metric.ts 100.00% <ø> (ø)
packages/opentelemetry-sdk-trace-web/src/utils.ts 65.62% <0.00%> (-29.38%) ⬇️
...s/opentelemetry-instrumentation-fetch/src/fetch.ts
...mentation-xml-http-request/src/enums/EventNames.ts
... and 10 more

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huge thanks to everyone that has been involved in the metrics project for this 🍾

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

@dyladan
Copy link
Member Author

dyladan commented Oct 24, 2022

Holding for #3357 please take a look at that. If we don't merge that, then the API can't be used with backwards compatible versions like the main API can

@dyladan dyladan merged commit e9347e4 into open-telemetry:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants