Skip to content

Conversation

@dyladan
Copy link
Member

@dyladan dyladan commented Oct 24, 2022

This check is done by the main API. This applies it to the metrics API so that compatible 1.x versions can be used together.

@dyladan dyladan requested a review from a team October 24, 2022 20:19
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #3357 (3d6ef1b) into main (4420402) will decrease coverage by 0.47%.
The diff coverage is 95.00%.

❗ Current head 3d6ef1b differs from pull request most recent head 19d3769. Consider uploading reports for the commit 19d3769 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3357      +/-   ##
==========================================
- Coverage   93.48%   93.00%   -0.48%     
==========================================
  Files         243      235       -8     
  Lines        7332     6593     -739     
  Branches     1512     1320     -192     
==========================================
- Hits         6854     6132     -722     
+ Misses        478      461      -17     
Impacted Files Coverage Δ
...telemetry-api-metrics/src/internal/global-utils.ts 90.90% <90.90%> (ø)
...s/opentelemetry-api-metrics/src/internal/semver.ts 97.61% <97.61%> (ø)
...kages/opentelemetry-api-metrics/src/api/metrics.ts 87.50% <100.00%> (+1.78%) ⬆️
api/karma.worker.js 0.00% <0.00%> (-100.00%) ⬇️
packages/opentelemetry-resources/karma.worker.js 0.00% <0.00%> (-100.00%) ⬇️
...ckages/opentelemetry-sdk-trace-web/karma.worker.js 0.00% <0.00%> (-100.00%) ⬇️
...kages/opentelemetry-sdk-trace-base/karma.worker.js 0.00% <0.00%> (-100.00%) ⬇️
...ges/opentelemetry-instrumentation-http/src/http.ts
...porter-metrics-otlp-grpc/src/OTLPMetricExporter.ts
...imental/packages/opentelemetry-sdk-node/src/sdk.ts
... and 6 more

@dyladan dyladan added release:required-for-ga size/M Denotes a PR that changes 30-99 lines, ignoring generated files. api:metrics Issues and PRs related to the Metrics API signal:metrics Issues and PRs related to general metrics signal pkg:api-metrics labels Oct 24, 2022
@dyladan dyladan merged commit d808e29 into open-telemetry:main Oct 26, 2022
@dyladan dyladan deleted the metrics-api-semver branch October 26, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api:metrics Issues and PRs related to the Metrics API pkg:api-metrics signal:metrics Issues and PRs related to general metrics signal size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants