fix(sdk-metrics): fix duplicated registration of metrics for collectors#3488
Merged
legendecas merged 2 commits intoopen-telemetry:mainfrom Jan 3, 2023
Merged
Conversation
legendecas
force-pushed
the
metrics/collector-registry
branch
from
9965e64 to
2e2a4be
Compare
legendecas
force-pushed
the
metrics/collector-registry
branch
from
2e2a4be to
fc98cc4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3488 +/- ##
=======================================
Coverage 93.78% 93.78%
=======================================
Files 249 249
Lines 7610 7610
Branches 1587 1587
=======================================
Hits 7137 7137
Misses 473 473
|
dyladan
approved these changes
Dec 15, 2022
Member
|
Simpler than expected fix |
pichlermarc
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #3472
Short description of the changes
MetricStorageRegistry.findOrUpdateCompatibleCollectorStoragealways returnsundefined, which leads to duplicated registration of metric storage for a collector.Type of change
How Has This Been Tested?
MetricStorageRegistry.findOrUpdateCompatibleCollectorStoragereturns the expected value.Checklist: