Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(sdk-metrics): fix duplicated registration of metrics for collectors
  • Loading branch information
legendecas committed Dec 15, 2022
commit fc98cc477e751663c4e621f85b631021344f35e7
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
* `telemetry.sdk.language`
* `telemetry.sdk.version`
* fix(selenium-tests): updated webpack version for selenium test issue [#3456](https://github.com/open-telemetry/opentelemetry-js/issues/3456) @SaumyaBhushan
* fix(sdk-metrics): fix duplicated registration of metrics for collectors [#3488](https://github.com/open-telemetry/opentelemetry-js/pull/3488) @legendecas

### :books: (Refine Doc)

Expand Down
2 changes: 1 addition & 1 deletion packages/sdk-metrics/src/state/MetricStorageRegistry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export class MetricStorageRegistry {
return null;
}

const storages = this._sharedRegistry.get(expectedDescriptor.name);
const storages = storageMap.get(expectedDescriptor.name);
if (storages === undefined) {
return null;
}
Expand Down
15 changes: 15 additions & 0 deletions packages/sdk-metrics/test/state/MetricStorageRegistry.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,22 @@ describe('MetricStorageRegistry', () => {

// registered the storage for each collector
assert.deepStrictEqual(registry.getStorages(collectorHandle), [storage]);
assert.strictEqual(
registry.findOrUpdateCompatibleCollectorStorage(
collectorHandle,
descriptor
),
storage
);

assert.deepStrictEqual(registry.getStorages(collectorHandle2), [storage]);
assert.strictEqual(
registry.findOrUpdateCompatibleCollectorStorage(
collectorHandle2,
descriptor
),
storage
);
});
});
});