docs(guidelines): add dependencies guidelines#4040
docs(guidelines): add dependencies guidelines#4040dyladan merged 20 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4040 +/- ##
==========================================
- Coverage 92.37% 90.52% -1.86%
==========================================
Files 321 159 -162
Lines 9273 3756 -5517
Branches 1970 835 -1135
==========================================
- Hits 8566 3400 -5166
+ Misses 707 356 -351 |
pichlermarc
left a comment
There was a problem hiding this comment.
Thanks for working on this 🙂
I've made some suggestions, no need to apply them all, feel free to change and adapt what fits 🙂
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
pichlermarc
left a comment
There was a problem hiding this comment.
Thanks for taking care of this 🙂
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
legendecas
left a comment
There was a problem hiding this comment.
The guidelines look good to me!
However, we have lots of files in the root directory already. It might be a good alternative to put the guideline in https://github.com/open-telemetry/opentelemetry-js/tree/main/doc.
Which problem is this PR solving?
After reading the discussion on #3847 and consulting other maintainers, I thought it would be good to write dependency guidelines.
Short description of the changes
Add GUIDELINES.md file. Currently contain only dependency guidelines.