feat: update PeriodicExportingMetricReader and PrometheusExporter to accept optional metric producers#4077
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4077 +/- ##
=======================================
Coverage 92.37% 92.37%
=======================================
Files 321 321
Lines 9276 9276
Branches 1970 1970
=======================================
Hits 8569 8569
Misses 707 707
|
…accept optional metric producers
15690f4 to
de059c3
Compare
dyladan
left a comment
There was a problem hiding this comment.
Looks good just one question. Why would the MetricProducer return a Resource if it is just going to be ignored? Is it used somewhere else?
We had a previous discussion about this #4007 (comment). The initial reason was to re-use the existing MetricProducer as is, which already had this signature. The existing
|
|
Could a maintainer merge this in? |
Which problem is this PR solving?
Part of #3461
Short description of the changes
Updated
PeriodicExportingMetricReaderandPrometheusExporterto accept optionalmetricProducersand pass them onto the superclassMetricReaderconstructor.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
This is a simple config change, but I tested them both manually.
Checklist: