fix: do not clear other labelsets when updating metrics#941
Merged
mayurkale22 merged 6 commits intoopen-telemetry:masterfrom Apr 7, 2020
Merged
fix: do not clear other labelsets when updating metrics#941mayurkale22 merged 6 commits intoopen-telemetry:masterfrom
mayurkale22 merged 6 commits intoopen-telemetry:masterfrom
Conversation
mayurkale22
approved these changes
Apr 7, 2020
obecny
reviewed
Apr 7, 2020
Member
obecny
left a comment
There was a problem hiding this comment.
can you add some unit test for that ?
mayurkale22
reviewed
Apr 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #941 +/- ##
==========================================
- Coverage 94.94% 94.94% -0.01%
==========================================
Files 247 248 +1
Lines 11142 11173 +31
Branches 1065 1068 +3
==========================================
+ Hits 10579 10608 +29
- Misses 563 565 +2
|
Member
Author
|
@obecny @mayurkale22 added tests |
vmarchaud
approved these changes
Apr 7, 2020
obecny
reviewed
Apr 7, 2020
markwolff
approved these changes
Apr 7, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…g included in release (open-telemetry#941)
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…g included in release (open-telemetry#941)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally reported by @obecny in gitter:
The following code:
Gave the following prometheus export:
Expected:
This was caused by two issues: