Skip to content

fix: do not clear other labelsets when updating metrics #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mayurkale22 merged 6 commits into from
Apr 7, 2020
Merged

fix: do not clear other labelsets when updating metrics #941

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0836414
fix: do not clear other labelsets when updating metrics
dyladan Apr 7, 2020
f644f4a
chore: add test for batcher
dyladan Apr 7, 2020
067d068
chore: test for one counter with multiple labels
dyladan Apr 7, 2020
af8a6a5
chore: lint
dyladan Apr 7, 2020
dcc1600
chore: fix year in copyright
dyladan Apr 7, 2020
41c7796
Merge branch 'master' into counter-labels
dyladan Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: test for one counter with multiple labels
  • Loading branch information
@dyladan
dyladan committed Apr 7, 2020
commit 067d068b90cfbcf625d2aa51c6bd995e9e202ee4
4 changes: 3 additions & 1 deletion packages/opentelemetry-exporter-prometheus/test/prometheus.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,13 +266,14 @@ describe('PrometheusExporter', () => {
});
});

it('should export multiple aggregations', done => {
it('should export multiple labelsets', done => {
const counter = meter.createCounter('counter', {
description: 'a test description',
labelKeys: ['counterKey1'],
}) as CounterMetric;

counter.bind({ counterKey1: 'labelValue1' }).add(10);
counter.bind({ counterKey1: 'labelValue2' }).add(20);
meter.collect();
exporter.export(meter.getBatcher().checkPointSet(), () => {
http
Expand All @@ -285,6 +286,7 @@ describe('PrometheusExporter', () => {
'# HELP counter a test description',
'# TYPE counter counter',
'counter{counterKey1="labelValue1"} 10',
'counter{counterKey1="labelValue2"} 20',
'',
]);

Expand Down