feat: Add experimental traceresponse propagator to Rack instrumentation #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plantfansam
requested changes
Nov 9, 2022
Contributor
plantfansam
left a comment
plantfansam
left a comment
There was a problem hiding this comment.
Seems like a great direction! Next up, tests 😄
instrumentation/rack/lib/opentelemetry/instrumentation/rack/instrumentation.rb
Outdated
Show resolved
Hide resolved
instrumentation/rack/lib/opentelemetry/instrumentation/rack/middlewares/tracer_middleware.rb
Outdated
Show resolved
Hide resolved
instrumentation/rack/opentelemetry-instrumentation-rack.gemspec
Outdated
Show resolved
Hide resolved
wperron
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
mwear,
robbkidd and
robertlaurin
as code owners
plantfansam
requested changes
Nov 10, 2022
...mentation/rack/test/opentelemetry/instrumentation/rack/middlewares/tracer_middleware_test.rb
Show resolved
Hide resolved
Adds an optional config for the rack instrumentation to use the [new traceresponse propagator][1]. [1]: open-telemetry/opentelemetry-ruby#1397
wperron
force-pushed
the
instrumentation-rack-tracesponse
branch
from
0f2fca2 to
d95e96b
Compare
plantfansam
requested changes
Nov 14, 2022
...mentation/rack/test/opentelemetry/instrumentation/rack/middlewares/tracer_middleware_test.rb
Outdated
Show resolved
Hide resolved
plantfansam
approved these changes
Nov 14, 2022
instrumentation/rack/lib/opentelemetry/instrumentation/rack/middlewares/tracer_middleware.rb
Show resolved
Hide resolved
instrumentation/rack/lib/opentelemetry/instrumentation/rack/instrumentation.rb
Show resolved
Hide resolved
robertlaurin
approved these changes
Nov 14, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional config for the rack instrumentation to use the new traceresponse propagator.