refactor!: Remove parent repo libraries #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielvalentin
requested review from
dazuma,
ericmustin,
fbogsany,
mwear,
plantfansam and
robertlaurin
as code owners
Removes any gems and references that belong to the `opentelemetry/opentelemetry-ruby` repository. Fixes open-telemetry#1
arielvalentin
force-pushed
the
remove-api-sdk-references
branch
from
5f5a11e to
87115fd
Compare
Contributor
Author
|
@robertlaurin Pushed up some fixes to deal with CI errors and updated the paths |
plantfansam
approved these changes
Jun 14, 2022
Contributor
plantfansam
left a comment
plantfansam
left a comment
There was a problem hiding this comment.
A masterpiece! I think this is good to merge. We'll inevitably discover stuff as we try to release new versions, but I think that's very OK.
| @@ -1,51 +0,0 @@ | |||
| # CHANGELOG | |||
| Released instrumentations can be found at the [OpenTelemetry registry](https://opentelemetry.io/registry/?language=ruby&component=instrumentation#). You can also look in this project's Github repository: Individual instrumentation libraries can be found in subdirectories under `/instrumentation`. | ||
|
|
||
| In-progress instrumentations can be found [here](https://github.com/open-telemetry/opentelemetry-ruby/issues?q=is%3Aopen+label%3Ainstrumentation+-label%3A%22help+wanted%22+). | ||
| In-progress instrumentations can be found [here](https://github.com/open-telemetry/opentelemetry-ruby-contrib/issues?q=is%3Aopen+label%3Ainstrumentation+-label%3A%22help+wanted%22+). |
Contributor
There was a problem hiding this comment.
Not a blocker at all, but for dicsussion: we'll need to migrate tickets over from otel-ruby eh? Or do we want to leave them there?
Contributor
Author
There was a problem hiding this comment.
We agreed that we would relocate only open issues to otel-ruby-contrib
instrumentation/pg/test/opentelemetry/instrumentation/pg/instrumentation_test.rb
Show resolved
Hide resolved
Contributor
|
Lots of minor comments around paths, do you want to handle that here or as a separate PR @arielvalentin |
Contributor
Author
|
@robertlaurin I would rather fix them here. |
Co-authored-by: Robert <[email protected]> Co-authored-by: Sam <[email protected]>
Co-authored-by: Robert <[email protected]>
robertlaurin
approved these changes
Jun 16, 2022
plantfansam
approved these changes
Jun 16, 2022
robertlaurin
pushed a commit
to open-telemetry/opentelemetry-ruby
that referenced
this pull request
Jun 20, 2022
* refactor: Remove Contrib Libraries This change removes libraries that were relocated to the contrib package. Related: open-telemetry/opentelemetry-ruby-contrib#1 See open-telemetry/opentelemetry-ruby-contrib#3 * chore: Rollback minitest Minitest 5.16 has changes that cause mock verification to fail in our test suite. Reverting to an earlier version allows tests to pass. https://github.com/open-telemetry/opentelemetry-ruby/runs/6928651844?check_suite_focus=true * fix: Apply suggestions from code review
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes any gems and references that belong to the
opentelemetry/opentelemetry-rubyrepository.Fixes #1