Skip to content

Mark service and telemetry.sdk resource attributes as stable. #3202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmacd merged 17 commits into from
Apr 4, 2023
Merged

Mark service and telemetry.sdk resource attributes as stable. #3202

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6b06fd4
Update semantic convention specification to mark important/required r…
jsuereth Feb 10, 2023
cb8cbe7
Merge remote-tracking branch 'origin/main' into wip-service-stability
jsuereth Feb 21, 2023
1e3c6dd
Split contentious attributes into experimental portions so we can mar…
jsuereth Feb 21, 2023
ed5a184
Mark attributes that were listed as required for SDKs as required to …
jsuereth Feb 22, 2023
3334481
Fix toc.
jsuereth Feb 22, 2023
69cf885
Fix yamllint errors.
jsuereth Feb 22, 2023
1a7a886
Merge remote-tracking branch 'origin/main' into wip-service-stability
jsuereth Feb 22, 2023
ae3df72
Merge branch 'main' into wip-service-stability
jsuereth Mar 13, 2023
7879a2c
Merge branch 'main' into wip-service-stability
jsuereth Mar 21, 2023
5bddb05
Merge branch 'main' into wip-service-stability
jsuereth Mar 28, 2023
c0f8cf4
Merge branch 'main' into wip-service-stability
jsuereth Apr 3, 2023
8aa57e0
Remove unecessary paragraph for attribute requirement level link.
jsuereth Apr 3, 2023
dfc5fcc
Add changelog.
jsuereth Apr 3, 2023
48f659d
Update to handle Tigran's comments.
jsuereth Apr 3, 2023
7b3242f
Clarify that custom identifiers should remain stable across their own…
jsuereth Apr 3, 2023
0ac3d66
Merge branch 'main' into wip-service-stability
jsuereth Apr 3, 2023
8328adc
Merge branch 'main' into wip-service-stability
jsuereth Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mark attributes that were listed as required for SDKs as required to … 
…avoid conflicting statements.
  • Loading branch information
@jsuereth
jsuereth committed Feb 22, 2023
commit ed5a184e5f7bb5d1a96bafea6b8e5ac622ec4a2c
3 changes: 3 additions & 0 deletions semantic_conventions/resource/telemetry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ groups:
attributes:
- id: sdk.name
type: string
requirement_level: required
brief: >
The name of the telemetry SDK as defined above.
examples: ["opentelemetry"]
Expand Down Expand Up @@ -36,10 +37,12 @@ groups:
value: "webjs"
- id: swift
value: "swift"
requirement_level: required
brief: >
The language of the telemetry SDK.
- id: sdk.version
type: string
requirement_level: required
brief: >
The version string of the telemetry SDK.
examples: ["1.2.3"]
Expand Down
6 changes: 3 additions & 3 deletions specification/resource/semantic_conventions/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,9 @@ The identifier SHOULD be stable across different versions of an implementation.
<!-- semconv telemetry -->
| Attribute | Type | Description | Examples | Requirement Level |
|---|---|---|---|---|
| `telemetry.sdk.name` | string | The name of the telemetry SDK as defined above. | `opentelemetry` | Recommended |
| `telemetry.sdk.language` | string | The language of the telemetry SDK. | `cpp` | Recommended |
| `telemetry.sdk.version` | string | The version string of the telemetry SDK. | `1.2.3` | Recommended |
| `telemetry.sdk.name` | string | The name of the telemetry SDK as defined above. | `opentelemetry` | Required |
| `telemetry.sdk.language` | string | The language of the telemetry SDK. | `cpp` | Required |
| `telemetry.sdk.version` | string | The version string of the telemetry SDK. | `1.2.3` | Required |

`telemetry.sdk.language` has the following list of well-known values. If one of them applies, then the respective value MUST be used, otherwise a custom value MAY be used.

Expand Down