-
Notifications
You must be signed in to change notification settings - Fork 941
Mark service and telemetry.sdk resource attributes as stable.
#3202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
6b06fd4
Update semantic convention specification to mark important/required r…
jsuereth cb8cbe7
Merge remote-tracking branch 'origin/main' into wip-service-stability
jsuereth 1e3c6dd
Split contentious attributes into experimental portions so we can mar…
jsuereth ed5a184
Mark attributes that were listed as required for SDKs as required to …
jsuereth 3334481
Fix toc.
jsuereth 69cf885
Fix yamllint errors.
jsuereth 1a7a886
Merge remote-tracking branch 'origin/main' into wip-service-stability
jsuereth ae3df72
Merge branch 'main' into wip-service-stability
jsuereth 7879a2c
Merge branch 'main' into wip-service-stability
jsuereth 5bddb05
Merge branch 'main' into wip-service-stability
jsuereth c0f8cf4
Merge branch 'main' into wip-service-stability
jsuereth 8aa57e0
Remove unecessary paragraph for attribute requirement level link.
jsuereth dfc5fcc
Add changelog.
jsuereth 48f659d
Update to handle Tigran's comments.
jsuereth 7b3242f
Clarify that custom identifiers should remain stable across their own…
jsuereth 0ac3d66
Merge branch 'main' into wip-service-stability
jsuereth 8328adc
Merge branch 'main' into wip-service-stability
jsuereth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| groups: | ||
| - id: service_experimental | ||
| prefix: service | ||
| type: resource | ||
| brief: > | ||
| A service instance. | ||
| attributes: | ||
| - id: namespace | ||
| type: string | ||
| brief: > | ||
| A namespace for `service.name`. | ||
| note: > | ||
| A string value having a meaning that helps to distinguish a group of services, | ||
| for example the team name that owns a group of services. | ||
| `service.name` is expected to be unique within the same namespace. | ||
| If `service.namespace` is not specified in the Resource then `service.name` | ||
| is expected to be unique for all services that have no explicit namespace defined | ||
| (so the empty/unspecified namespace is simply one more valid namespace). | ||
| Zero-length namespace string is assumed equal to unspecified namespace. | ||
| examples: ["Shop"] | ||
| - id: instance.id | ||
| type: string | ||
| brief: > | ||
| The string ID of the service instance. | ||
| note: > | ||
| MUST be unique for each instance of the same `service.namespace,service.name` pair | ||
| (in other words `service.namespace,service.name,service.instance.id` triplet MUST be globally unique). | ||
| The ID helps to distinguish instances of the same service that exist at the same time | ||
| (e.g. instances of a horizontally scaled service). It is preferable for the ID to be persistent | ||
| and stay the same for the lifetime of the service instance, however it is acceptable that | ||
| the ID is ephemeral and changes during important lifetime events for the service | ||
| (e.g. service restarts). | ||
| If the service has no inherent unique ID that can be used as the value of this attribute | ||
| it is recommended to generate a random Version 1 or Version 4 RFC 4122 UUID | ||
| (services aiming for reproducible UUIDs may also use Version 5, see RFC 4122 | ||
| for more recommendations). | ||
| examples: ["my-k8s-pod-deployment-1", "627cc493-f310-47de-96bd-71410b7dec09"] | ||
| - id: version | ||
| type: string | ||
| brief: > | ||
| The version string of the service API or implementation. | ||
| examples: ["2.0.0"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| groups: | ||
| - id: telemetry_experimental | ||
| prefix: telemetry | ||
| type: resource | ||
| brief: > | ||
| The telemetry SDK used to capture data recorded by the instrumentation libraries. | ||
| attributes: | ||
| - id: auto.version | ||
| type: string | ||
| brief: > | ||
| The version string of the auto instrumentation agent, if used. | ||
| examples: ["1.2.3"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.